Re: master fcade74066d 1/2: src/comp.c: Use `pending_funcalls` to fix bug#64494

Re: master fcade74066d 1/2: src/comp.c: Use `pending_funcalls` to fix bug#64494

[Po Lu]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

> @@ -5674,13 +5666,6 @@ void
>  syms_of_comp (void)
>  {
>  #ifdef HAVE_NATIVE_COMP
> -  DEFVAR_LISP ("comp--delayed-sources", Vcomp__delayed_sources,
> -    doc: /* List of sources to be native-compiled when startup is finished.
> -For internal use.  */);
> -  DEFVAR_BOOL ("comp--compilable", comp__compilable,
> -    doc: /* Non-nil when comp.el can be native compiled.
> -For internal use. */);
> -  /* Compiler control customizes.  */
>    DEFVAR_BOOL ("native-comp-jit-compilation", native_comp_jit_compilation,
>      doc: /* If non-nil, compile loaded .elc files asynchronously.
>  
> @@ -5798,6 +5783,8 @@ natively-compiled one.  */);
>          build_pure_c_string ("eln file inconsistent with current runtime "
>  			     "configuration, please recompile"));
>  
> +  DEFSYM (Qnative__compile_async, "native--compile-async");

Minor nit: shouldn't this be named `comp--compile-async' or
`native-comp--compile-async'?

Re: master fcade74066d 1/2: src/comp.c: Use `pending_funcalls` to fix bug#64494

[Stefan Monnier]

>> +  DEFSYM (Qnative__compile_async, "native--compile-async");
> Minor nit: shouldn't this be named `comp--compile-async' or
> `native-comp--compile-async'?

[ Side note: I did not choose this name, I only replaced `intern
  ("native--compile-async")` with this DEFSYM.  ]

It does seem inconsistent, indeed.
`comp--compile-async' would be my choice.


        Stefan