From: Daniel Mendler via "Emacs development discussions." <emacs-devel@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: Eshel Yaron <me@eshelyaron.com>,
Stefan Kangas <stefankangas@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Possible minibuffer completion enhancements
Date: Mon, 22 Jan 2024 09:12:19 +0100 [thread overview]
Message-ID: <87a5ox7png.fsf@daniel-mendler.de> (raw)
In-Reply-To: <86v87l4xii.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 22 Jan 2024 09:50:45 +0200")
Juri Linkov <juri@linkov.net> writes:
>> I've rebased the feature/minibuffer-completion-enhancements branch on
>> top of the current master, and pushed it to emacs.git. Looking forward
>> for your thoughts and feedback!
>
> Thanks, I tried 'C-x C-v' (minibuffer-sort-completions),
> and it works nicely. But I can't imagine how the whole
> branch could be merged to master when it contains
> so diverse set of different features.
I agree. I suggest to create a set of separate patches, e.g., as
follows:
1. Helper functions, e.g., completion-table-with-metadata
2. CRM refactoring
3. Cycle commands for sorting
4. Cycle commands for completion styles
5. Annotation functions
6. Narrowing commands
Regarding 5 and 6 it would be great to explore an alternative approach
with a :property-function because of the additional flexibility and
extensibility. We would get a lot of functionality for free.
Iirc Stefan Monnier had plans to change the implementation of the
completion machinery, rebasing it on a cl-defgeneric mechanism, where
completion tables provide cl-defmethods. If more and more additional
completion candidate metadata is supplied, looking into this again may
be worthwhile.
> For example, probably everyone would agree that
> 'completion-table-with-metadata' could be installed
> in master immediately (if you present a separate patch).
> But other feature might require more discussion.
Indeed. However the implementation of completion-table-with-metadata
I've seen in Eshel's branch did not seem correct. The function should be
simpler:
(defun completion-table-with-metadata (table metadata)
(lambda (str pred action)
(if (eq action 'metadata)
`(metadata ,@metadata
,@(and (functionp table)
(cdr (funcall table str pred action))))
(complete-with-action action table str pred))))
Daniel
next prev parent reply other threads:[~2024-01-22 8:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 17:28 Possible minibuffer completion enhancements Eshel Yaron
2024-01-15 12:19 ` Eli Zaretskii
2024-01-16 13:47 ` Eshel Yaron
2024-01-16 14:10 ` Eli Zaretskii
2024-01-17 18:57 ` Eshel Yaron
2024-01-15 21:35 ` Stefan Kangas
2024-01-16 13:58 ` Eshel Yaron
2024-01-16 22:44 ` Stefan Kangas
2024-01-17 19:17 ` Eshel Yaron
2024-01-17 21:17 ` Stefan Kangas
2024-01-19 12:31 ` Eshel Yaron
2024-01-21 9:03 ` Eshel Yaron
2024-01-21 11:04 ` Daniel Mendler via Emacs development discussions.
2024-01-21 14:49 ` Eshel Yaron
2024-01-22 7:50 ` Juri Linkov
2024-01-22 8:12 ` Daniel Mendler via Emacs development discussions. [this message]
2024-01-22 12:18 ` Eshel Yaron
2024-01-22 12:35 ` Eshel Yaron
2024-01-23 8:08 ` Daniel Mendler via Emacs development discussions.
2024-01-22 20:31 ` Daniel Mendler via Emacs development discussions.
2024-01-23 7:04 ` Eshel Yaron
2024-01-23 8:00 ` Daniel Mendler via Emacs development discussions.
2024-01-23 16:23 ` Eshel Yaron
2024-01-23 18:32 ` Daniel Mendler via Emacs development discussions.
2024-01-24 2:32 ` Madhu
2024-01-22 21:11 ` Philip Kaludercic
2024-01-23 7:33 ` Eshel Yaron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ox7png.fsf@daniel-mendler.de \
--to=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=mail@daniel-mendler.de \
--cc=me@eshelyaron.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).