From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: master 4b79c80c999 1/2: New function 'sort-on' Date: Fri, 02 Feb 2024 16:26:58 +0100 Message-ID: <87a5oij399.fsf@daniel-mendler.de> References: <170688047526.14693.2994051491358257471@vcs2.savannah.gnu.org> <20240202132756.4272CC0EFE7@vcs2.savannah.gnu.org> <87cytej4hy.fsf@daniel-mendler.de> <86zfwi52m1.fsf@gnu.org> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38561"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 02 16:27:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVvRz-0009m0-Vv for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Feb 2024 16:27:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVvRg-0001Ns-RN; Fri, 02 Feb 2024 10:27:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvRa-0001JC-Lj for emacs-devel@gnu.org; Fri, 02 Feb 2024 10:27:07 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvRX-0007Ty-Lo; Fri, 02 Feb 2024 10:27:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7kiq86jjXeAhp6fM4m6jXzJHqy76Al+F1JtFndFKuN0=; b=wPoRc0+bjTCz9tUsGUrKL7upnV T3jHxQYOtEVB1Dxyym+zWRcXzqh++uZ1DfR6P7ZsBu8dY0lPRsaqaJWLkF41gHMl1jDUTnsPLoiF4 Y6gb8Yx504z+MJ3HsmmcT+EBRAt5v3154DN2M8uIufSgnthEZQCj6BjEUD/BdP4ba1r4=; In-Reply-To: <86zfwi52m1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Feb 2024 17:04:38 +0200") Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315754 Archived-At: Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: Eli Zaretskii >> Date: Fri, 02 Feb 2024 16:00:09 +0100 >> >> Eli Zaretskii writes: >> >> > branch: master >> > commit 4b79c80c999fe95654b7db196b12e0844473f6da >> > Author: Eli Zaretskii >> > Commit: Eli Zaretskii >> > >> > New function 'sort-on' >> > >> > * lisp/sort.el (sort-on): New function. Patch by John Wiegley >> > . >> > >> > * etc/NEWS: >> > * doc/lispref/sequences.texi (Sequence Functions): Document >> > 'sort-on'. >> >> Would this function fit into the seq library, named seq-sort-on? > > "Fit" in what sense? The function works with other sequence types too and it seems a good idea to collect sequence-related functionality in seq.el. > This function can only sort lists, so at least from that aspect its > place is not in seq.el. In addition, I see no reason to have it > preloaded. No, in the current form, the function works on vectors too. It always returns a list though. But maybe it makes sense to generalize it such that it returns the same type as the argument. > I've put it in sort.el because the function 'sort' is there. No, sort is defined in src/fns.c. Daniel