From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu <luangruo@yahoo.com> Newsgroups: gmane.emacs.devel Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64. Date: Thu, 08 Feb 2024 11:34:04 +0800 Message-ID: <87a5ob4ok3.fsf@yahoo.com> References: <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org> <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org> <CADwFkmmK+r6Q_GdTa++PaZRm3ngQ_ueXR2yfzN8RaS607dUiOg@mail.gmail.com> <87plx74u0i.fsf@yahoo.com> <0e8b1009-1491-2fb7-9efc-c415ed66d334@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4484"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas <stefankangas@gmail.com>, emacs-devel@gnu.org, eliz@gnu.org To: Jim Porter <jporterbugs@gmail.com> Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 04:35:14 2024 Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org> Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>) id 1rXvBx-00013l-9U for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 04:35:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <emacs-devel-bounces@gnu.org>) id 1rXvB7-0006Zy-Gp; Wed, 07 Feb 2024 22:34:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <luangruo@yahoo.com>) id 1rXvB5-0006Zk-TX for emacs-devel@gnu.org; Wed, 07 Feb 2024 22:34:19 -0500 Original-Received: from sonic317-33.consmr.mail.ne1.yahoo.com ([66.163.184.44]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <luangruo@yahoo.com>) id 1rXvB4-0000Rf-85 for emacs-devel@gnu.org; Wed, 07 Feb 2024 22:34:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1707363255; bh=fToWHHT2dp4UewYnHUbYsLY+WbI8RcPSUslo7rHmmgk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=fjew/RxP0PskV63ygdL12IaroaG8LA6wj1XuMqpF+X40uFTZxPgyF+pi1MxxIlFAEmtS+f4qMmaRc0fm4jy3FeJRj2W3NZNNPKBeozEyl98ns6NQxBq6C3FR9BImPYm4lIcM0OXBYFkp3FaqI3D4FekqS8wsV/PLYP8V8C18eT1/AjfAUc33ahmM6aPpQ/2J4t/f/g8MZcdRqyyELr4UqJrrHYpHo+KF0O88XGbYyXzoUUiH+OFcLjLRsrsijsJavFRUEbCTRjlaB0A2J5YwdXtB52XOYHIVgW8weIPGgnr1VSjH3Z7MEg34Fc1LU8e2dUJB21Yk62preDD8ghm43Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1707363255; bh=9JqEXfK/8tQ/Yj9Wj3EQTjNWwsNhwgYesMYgWUnA1aP=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=TQIRwINFu6bcVHAaJ02zZ/HghFfUXQMgF5FRwCjpcS8ohxqA7tg55WIT5zYIEk2b1mVYyiIbz+0G+a5c8QyEWtVmQ2hn5WD2+i5ZcYPW6o/ZxhiRAooOlpiR1G7gYBS/FUG/4IMyGVhEvFv7wv+Y1Rf5g+mQUcKb7nNldn3R2Ek70sGtYgB2SMG6FbpJRiKUGQnUQ1ThIQflDbzdnSwQWLnE4vSNpkxt2Q/mMH2H1Q4zcI64mZszUcRb69gXXP5kJpM9DLffZ48A3st6Kljy6IBnppWq/pQN2iBhyMPjxLc7XHGmG7QdSBdOIErXhEolU3F/FiiYmZQromL+1ydPdw== X-YMail-OSG: 4GpHxfEVM1mKa_nkrGKCyy4yQsAQGYpZTZ0ipBN.Xgach3BR6Lc4tjafwB9RCP5 rHBuyWq_zB2fJ5Ejtc8K9i3uRPmsF8hKyMCQZhCw7V54QDy_PSg0To.DyLORAN05SyiCCBpVhexv 0jeEZEGxE0TxEDypgKd_f0rZgZeX47QT2vUITeeWezbre0BxLAMvuvP_fNmg8kTIwlFIesIXtV.m GOCGnoO6LC.7_egneeWI7PT1oNXgS5jA49FA4U4C1EF2q.jqfxfAgH5ZLpWSW3W3QZIf7NVWsMI0 b9dAGX.MSJM1oDdg358Nr5ZRScjLxVr5JcGGxajlIUvUy5VdrMD.sm3ZplnmSOPh3bVCqKPhtgM7 q3OrbNB0vhEJGFcis1SkevvfN0m2aCSbNP_UkMmYMjone3PaHz3eyWc12TAGp.PgI5W4hte..0V5 bb7BOH.HfRLQBAMU3QWD8TvkRxjAh4WSq4S4.raJ.6pUpCX3L6m0fHBSNEnsI3jfAMkUK9SdflB0 amTk5y3FMNRHJuHg9MplWKBfg10l95FjZBM7drI.tQn3Ezq9XHO6Fh4dmW6nccR0Xfmm1Cqz9t6k DyQkPUsH1iGIN6FhR.ikqWEz_6E2Y6LejTW5AJWlQDM.lO6r9NKiBNjrr10UMoqsOiKAZxR9o6HY h422uKKma8M7b1O7DtmO1yALztJAOmMSuptWYj9JnACwUNS4dujbcLYDyU43IVo97WTC6iMjyOQg VwG4Z4Lp4U8NMVhSuWyepLCHeJSZcST4A9twSlompTtpFdHOeG8xttk_Oc.xctLrLz8RVMR4bScx 3H7C4INoG3wQOmDVt2A33Dy6uEEUW9BqgBFstb3MbK X-Sonic-MF: <luangruo@yahoo.com> X-Sonic-ID: 8ab7410c-146a-4045-821d-bf1cd7f35185 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Thu, 8 Feb 2024 03:34:15 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-bcm5n (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2ac695aea308e3e479cfe2bb37be5180; Thu, 08 Feb 2024 03:34:11 +0000 (UTC) In-Reply-To: <0e8b1009-1491-2fb7-9efc-c415ed66d334@gmail.com> (Jim Porter's message of "Wed, 7 Feb 2024 19:10:14 -0800") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.44; envelope-from=luangruo@yahoo.com; helo=sonic317-33.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." <emacs-devel.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>, <mailto:emacs-devel-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/emacs-devel> List-Post: <mailto:emacs-devel@gnu.org> List-Help: <mailto:emacs-devel-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>, <mailto:emacs-devel-request@gnu.org?subject=subscribe> Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316009 Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/316009> Jim Porter <jporterbugs@gmail.com> writes: > Aren't the entries in ChangeLogs indented by one tab (so 8 characters > by default), which would mean that if we want to fill the ChangeLog to > 74 columns, we actually want log-edit-mode to fill to 74 - 8 = 66 > columns? In the other thread, Eli stated that the correct fill-column is 65, which is equivalent to 64 in log-edit-mode. > That passage was last changed by Eli (CCed) in 2022 (commit > 161cb6034cec). Previously, it said this: True, but the definitive setting lies elsewhere, in `add-log.el': (setq left-margin 8 fill-column 74 indent-tabs-mode t tab-width 8 show-trailing-whitespace t) which has existed since the beginning of time, or thereabouts. > (There was a sentence after that recommending the first line be <=50 > columns moved elsewhere in 2021, but otherwise, that passage has been > that way from 2015 until Eli's change.) > > In any case, if the intent is really to limit *ChangeLog entries* to > 78/140 columns instead of *commit messages*, then the commit hook that > CONTRIBUTE mentions is wrong; it checks for exceeding 78/140 columns > in the commit message. We wish to limit ChangeLog entries to _74_ columns, while leaving the door open to exceeding that limit for messages that are impossible to fill neatly within it. > I don't have a terribly strong opinion here of what number to use, but > we should at least resolve the inconsistencies in CONTRIBUTE, > .dir-locals.el, and build-aux/git-hooks/commit-msg. commit-msg is fine as-is, but CONTRIBUTE should be fixed.