unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Semyonov <daniel@dsemy.com>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: Michael Albinus <michael.albinus@gmx.de>,
	 Eric Abrahamsen <eric@ericabrahamsen.net>,
	 emacs-devel@gnu.org
Subject: Re: master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom)
Date: Mon, 29 Apr 2024 21:39:08 +0300	[thread overview]
Message-ID: <87a5lc57zn.fsf@dsemy.com> (raw)
In-Reply-To: <70BFC2F4-E3F5-4515-9FEE-F293BDE1D3D3@gmail.com> ("Mattias Engdegård"'s message of "Mon, 29 Apr 2024 19:14:23 +0200")

>>>>> Mattias Engdegård writes:

    > 29 apr. 2024 kl. 18.42 skrev Michael Albinus <michael.albinus@gmx.de>:
    >> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
    >> 
    >>> This is still failing the tests, and I can't see why, I suspect the
    >>> reason is in the "... ..." below:

    > No, you should ignore that and look at the text

    >> The following options might have problems:
    >> variable: gnus-valid-select-methods
    >> value: (...)
    >> type: (...)


    > that precedes the ERT error. In this case, it appears that the top-level list includes an element

    >   ("nnatom" address)

    > which doesn't match the declared type which requires that the string be followed by one of {post, mail, none, post-mail}.


This should be changed to `("nnatom" none address)', and the docstring
should probably be changed to clarify this too.

Honestly though, I don't understand why this is a user option in the
first place, it only seems useful if you're implementing a new backend
(in which case, you're probably using `gnus-declare-backend', which
modifies `gnus-valid-select-methods' without checking the value anyway).

Daniel



  reply	other threads:[~2024-04-29 18:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171389641522.15334.4055859790974801392@vcs2.savannah.gnu.org>
     [not found] ` <20240423182018.97FA3C12C33@vcs2.savannah.gnu.org>
2024-04-28 10:53   ` master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom) Michael Albinus
2024-04-28 17:08     ` Eric Abrahamsen
2024-04-28 23:53       ` Eric Abrahamsen
2024-04-29 16:42         ` Michael Albinus
2024-04-29 17:14           ` Mattias Engdegård
2024-04-29 18:39             ` Daniel Semyonov [this message]
2024-04-29 20:12               ` Eric Abrahamsen
2024-04-29 21:02                 ` Daniel Semyonov
2024-04-30  6:59                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5lc57zn.fsf@dsemy.com \
    --to=daniel@dsemy.com \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=mattias.engdegard@gmail.com \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).