[PATCH] Re: Value of rmail-total-messages in the summary buffer

[Andrea Monaco <andrea.monaco@autistici.org>]

  > Please show some simple recipe that exhibits the problem, as I'm not
  > sure I understand how does that get in the way.

If I make a small summary by topic, say on this very topic, and then
from the summary buffer I call rmail-summary-by-thread, again on this
thread, I get an out-of-bounds error.  Can you replicate this?


  > Also, are you saying that the previous "buggy" value did not present
  > the same problem?  If so, can you explain why?

Thinking more about it, the problem originated in
8729a2a10d9b8d88f6ba33b5ce62f74d89e7788a and is easier to solve.  The
attached patch solves the problem for me: the reference to
rmail-total-messages now happens inside rmail-buffer, so the intended
value is taken.


  > I don't think I agree.  I think it will be very confusing if the
  > number in summary buffer's mode-line didn't reflect the actual
  > number of messages in the summary buffer.

Does rmail-total-messages get displayed somewhere?  I didn't know that.



Andrea Monaco




    * lisp/mail/rmailsum.el (rmail-summary-by-thread): Fix bug: get the
    right binding of rmail-total-messages.


diff --git a/lisp/mail/rmailsum.el b/lisp/mail/rmailsum.el
index 48c5cb70b33..2a504ca5a68 100644
--- a/lisp/mail/rmailsum.el
+++ b/lisp/mail/rmailsum.el
@@ -430,14 +430,15 @@ rmail-summary-by-thread
    (let* ((msg rmail-current-message)
          (prompt (concat "Show thread containing message number")))
      (list (read-number prompt msg))))
-  (with-current-buffer rmail-buffer
-    (unless msgnum
-      (setq msgnum rmail-current-message))
-    (unless (and rmail-summary-message-parents-vector
-                (= (length rmail-summary-message-parents-vector)
-                   (1+ rmail-total-messages)))
-      (rmail-summary-fill-message-parents-and-descs-vectors)))
-  (let ((enc-msgs (make-bool-vector (1+ rmail-total-messages) nil)))
+  (let (enc-msgs)
+    (with-current-buffer rmail-buffer
+      (setq enc-msgs (make-bool-vector (1+ rmail-total-messages) nil))
+      (unless msgnum
+       (setq msgnum rmail-current-message))
+      (unless (and rmail-summary-message-parents-vector
+                  (= (length rmail-summary-message-parents-vector)
+                     (1+ rmail-total-messages)))
+       (rmail-summary-fill-message-parents-and-descs-vectors)))
     (rmail-summary--walk-thread-message-recursively msgnum enc-msgs)
     (rmail-new-summary (format "thread containing message %d" msgnum)
                       (list 'rmail-summary-by-thread msgnum)