From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar Newsgroups: gmane.emacs.devel Subject: Re: ELPA package: filechooser Date: Tue, 16 Jul 2024 10:59:38 +0200 Message-ID: <87a5ihpv9h.fsf@zohomail.eu> References: <87r0bxqms0.fsf@zohomail.eu> <87bk30jguc.fsf@localhost> <87ikx7ra2i.fsf@zohomail.eu> <87h6cqii5c.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10904"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.1; emacs 29.4 Cc: Thierry Volpiatto , Eli Zaretskii , mardani29@yahoo.es, emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 11:51:11 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTepz-0002Zo-7T for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 11:51:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTeoz-0005kn-Kc; Tue, 16 Jul 2024 05:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTe2P-0007Cn-RJ for emacs-devel@gnu.org; Tue, 16 Jul 2024 04:59:57 -0400 Original-Received: from sender-pp-o91.zoho.eu ([136.143.169.91]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTe2G-00008Y-SA; Tue, 16 Jul 2024 04:59:57 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1721120381; cv=none; d=zohomail.eu; s=zohoarc; b=U/ftOPMUtIIxZLqN0fph1BnidwP+vE3/ZWOQSStqNQeSTYl3PN62a83iHHhnP8d8eGuuS5Q/NZWmQX2rx9g75syvyfjnxQiMh65jHZKYzma2WsEdhyK23x9BhtYFM9LZObqWnacDpBB5I+7lPHrpLsoORLTwYAQpamYXqpO6KcQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1721120381; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uq+yZ5UYcq1eOEoCQBbA5PY7kByDLhC0a6i2lh1fT3A=; b=N5ih/C5NrZhO1Uh416ij7UIQ/m6qAMdCn3vdHL3bEUReK6wfoYaId1Yy/EFKbL97JGbSWTiYdKTqNYgIWXiU7mIIWpbviL9W+W+mumkNwtLPFEYQr435djjrwQGs3XRXs5cSDTQ5e/mAGRdGG/EsFuv83u3lnVdwmmMRrl61Ba8= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1721120381; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=Uq+yZ5UYcq1eOEoCQBbA5PY7kByDLhC0a6i2lh1fT3A=; b=M9cNp6z2gYgm5hRJPi2cxQ10FP/giocj160ExKvdjv605gSqZy4Y49rDUntIJiw3 dbteSTpWBFwqyIQK9uLm8JZ00eCTiuHoQAyADuGoU/VdnR+BN3+ole0Is45dY9loXUB 8vVaqI1cg7JKK4Toc42x1XaQtjm3IfryR6GIuDYA= Original-Received: by mx.zoho.eu with SMTPS id 1721120379394659.2978552558765; Tue, 16 Jul 2024 10:59:39 +0200 (CEST) In-Reply-To: <87h6cqii5c.fsf@localhost> (Ihor Radchenko's message of "Mon, 15 Jul 2024 19:12:31 +0000") X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.169.91; envelope-from=rahguzar@zohomail.eu; helo=sender-pp-o91.zoho.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 16 Jul 2024 05:50:05 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321692 Archived-At: Ihor Radchenko writes: > Rahguzar writes: > >>> M-TAB selects file. >>> I did not find how to remove selected file. >> >> M-TAB on a selected file deselects it. It is basically a toggle. > > Now got it. You are right. I did not realize that I need to narrow the > completions to the file I want to toggle. Just assumed that M-tab will > act on what is displayed on top in the completions buffer, which is the > first selected file - I was wrong. > >>> A side note: The usual /old/path/to/file/~/restart/path does not work as expected. >> >> Can you please describe how it doesn't work? It works for me with >> vertico. I thought let binding minibuffer-completing-file-name was >> enough to get rfn-eshadow to work. > > In short, I tried > > 1. Input ~/Git/emacs/src/xdisp.c > 2. M-tab > 3. ~/Git/emacs/src/~/ > > and the completion list is empty. > > I recorded a short video demonstrating the problem. > https://0x0.st/XLFm.mkv You are right. The problem essentially boils down to this: (let ((minibuffer-completing-file-name t)) (completing-read "File: " #'completion-file-name-table)) The shadowing works as expected using vertico but not in the default completion UI. I will try to figure out how exactly that is supposed to be handled but I think the best place will be the completion-file-name-table since otherwise every user of the table (or the completion UI) needs to implement this behavior. Rahguzar