From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: avoid duplicates in history Date: Sat, 05 Jun 2004 01:09:38 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <878yf3vuu4.fsf@mail.jurta.org> References: <200406011700.i51H0MGK001165@scanner2.ics.uci.edu> <87llj4gguw.fsf@mail.jurta.org> <200406041629.i54GTDGK020998@scanner2.ics.uci.edu> <871xkv3yrv.fsf@mail.jurta.org> <200406042127.i54LRGGK023448@scanner2.ics.uci.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1086387428 5343 80.91.224.253 (4 Jun 2004 22:17:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 4 Jun 2004 22:17:08 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Jun 05 00:17:03 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BWMzn-0007lf-00 for ; Sat, 05 Jun 2004 00:17:03 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BWMzm-0007zN-00 for ; Sat, 05 Jun 2004 00:17:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BWN0B-0000jp-W4 for emacs-devel@quimby.gnus.org; Fri, 04 Jun 2004 18:17:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BWN09-0000jZ-5B for emacs-devel@gnu.org; Fri, 04 Jun 2004 18:17:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BWN07-0000jL-5p for emacs-devel@gnu.org; Fri, 04 Jun 2004 18:17:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BWN07-0000jI-3M for emacs-devel@gnu.org; Fri, 04 Jun 2004 18:17:23 -0400 Original-Received: from [66.33.219.6] (helo=knife.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BWMzH-0000ep-MW for emacs-devel@gnu.org; Fri, 04 Jun 2004 18:16:31 -0400 Original-Received: from mail.jurta.org (80-235-37-117-dsl.mus.estpak.ee [80.235.37.117]) by knife.dreamhost.com (Postfix) with ESMTP id 685A9E4050; Fri, 4 Jun 2004 15:16:29 -0700 (PDT) Original-To: Dan Nicolaescu In-Reply-To: <200406042127.i54LRGGK023448@scanner2.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 04 Jun 2004 14:27:17 -0700") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24548 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24548 Dan Nicolaescu writes: > Juri Linkov writes: > > This condition is redundant when `history-delete-duplicates' is t. > > I believe this is fine, that condition just avoids adding consecutive > identical entries, there's no need to do anything when that condition > is false. It can't delete duplicates if the history contains several of them. This is possible when the value of `history-delete-duplicates' is changed during the Emacs session. But when it is set in .emacs, your patch will guarantee that no duplicates are added to the history. So for the case when the value `history-delete-duplicates' isn't changed during the Emacs session, your patch is ok. -- Juri Linkov http://www.jurta.org/emacs/