unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marcelo Toledo <marcelo@marcelotoledo.org>
Subject: Re: [dann@ics.uci.edu: grep fontification problem]
Date: Fri, 06 May 2005 14:56:06 -0300	[thread overview]
Message-ID: <878y2s6xxl.fsf@kali.intranet> (raw)
In-Reply-To: <E1DTMUr-0006PO-N4@fencepost.gnu.org> (Richard Stallman's message of "Wed, 04 May 2005 12:13:13 -0400")

In 2004/04/05 we started a thread about highlighting grep buffer, the
code mentioned there uses the ansi codes of grep and activates the
`ansi-color-apply-on-region'.

This solution is partially acceptable, will work for most of the users,
but will fail for non GNU Grep, I cannot customize it in Emacs which is
bad in my opinion because may not look good in all displays and every
once grep changes their code, we have to make sure it will not break our
solution and it will still be highlighting correctly.

For some reason the solution nowadays looks pretty much confusing, it
uses the ansi codes generated from grep, doesn't activate ansi in the
region and the codes are stripped in the future.

In 26 Apr 2005 17:24:24 Stefan suggested something, but I can only
realize that we have been fighting against a wrong solution that we took
in the past.

Whatever is going on we have no complex highlight here so I don't see
why we should still stick with the ansi colors. This is turning the
source code complicated, longer, dependent and non-customizable in
Emacs.

Richard Stallman <rms@gnu.org> writes:

> Is someone working on this problem?  Please tell me if you are.
>
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Subject: grep fontification problem
> To: emacs-pretest-bug@gnu.org
> X-Sent: 3 days, 15 hours, 21 minutes, 16 seconds ago
> X-Spam-Level: 
>
>
> Save the following to /tmp/t
>
> - ---cut here---
> abc def abc def
> def abc def
> - ---cut here---
>
> and then do M-x grep RET abc /tmp/t RET
>
> the grep buffer will look like:
>
> - -*- mode: grep; default-directory: "/tmp/" -*-
> grep -nH -e abc /tmp/t
> T:1:abc def ^[[01;41mabc^[[00m^[[K def
> T:2:def abc def
>
> Grep finished (matches found) at Mon May  2 18:57:15
>
> The escape sequence for the second "abc" string was not eliminated and
> replaced with a face. 

-- 
Marcelo Toledo
marcelo@marcelotoledo.org
http://www.marcelotoledo.org
Mobile: 55 71 9116-1101

  reply	other threads:[~2005-05-06 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-04 16:13 [dann@ics.uci.edu: grep fontification problem] Richard Stallman
2005-05-06 17:56 ` Marcelo Toledo [this message]
2005-05-07 18:36   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878y2s6xxl.fsf@kali.intranet \
    --to=marcelo@marcelotoledo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).