From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PING] ClearType Patch Date: Wed, 08 Jun 2005 12:44:23 -0400 Message-ID: <878y1khko6.fsf-monnier+emacs@gnu.org> References: <1117787455.42a0153fdf46f@webmail.freedom2surf.net> <1118072836.42a47004de422@webmail.freedom2surf.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1118249121 10863 80.91.229.2 (8 Jun 2005 16:45:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Jun 2005 16:45:21 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 08 18:45:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dg3d4-0006Uw-5q for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 18:42:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dg3jo-0006Rd-L0 for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 12:49:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dg3j9-0006E3-14 for emacs-devel@gnu.org; Wed, 08 Jun 2005 12:48:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dg3j6-0006Cr-LJ for emacs-devel@gnu.org; Wed, 08 Jun 2005 12:48:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dg3j6-0006Co-HO for emacs-devel@gnu.org; Wed, 08 Jun 2005 12:48:24 -0400 Original-Received: from [209.226.175.34] (helo=tomts13-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dg3iq-0006Bv-Aq; Wed, 08 Jun 2005 12:48:08 -0400 Original-Received: from alfajor ([67.71.116.59]) by tomts13-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050608164424.ITZX25800.tomts13-srv.bellnexxia.net@alfajor>; Wed, 8 Jun 2005 12:44:24 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id CDDAED73A3; Wed, 8 Jun 2005 12:44:23 -0400 (EDT) Original-To: David Abrahams In-Reply-To: (David Abrahams's message of "Wed, 08 Jun 2005 11:46:58 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38353 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38353 > Sorry, but I have a lot on my plate, so once I start waiting a few > more days it's likely to drop off my radar screen. I know exactly how that feels. I have about 1MB of local hacks, which have all "fallen off the radar": I use them but they're not clean enough to be installed. >> Finally, MSDN seems to indicate that SPI_GETFONTSMOOTHINGTYPE is >> unsupported on Windows 9x, so it sounds like your code should be >> disabled for those versions of Windows. > Right, I should use an #ifdef _WIN32_WINNT >= 0x0501 ... except of > course that the build process subverts that by forcing _WIN32_WINNT to > 0x400. I don't use w32 and I know nothing about its APIs, so I don't know how best to solve the conflict between the -D_WIN32_WINNT=0x0400 and your duplicate defines, but I think that if the code is left as you've written it, you should explain it in the code (rather than in this thread) with a comment. Such a comment can also be used to vent any frustration you may have at the -D_WIN32_WINNT=0x0400 flag. This said, I hope some version of your patch will be installed because I find the truncation of anti-aliased glyphs (which I have noticed the few rare times I've used NTEmacs) isn't just ugly but makes the use of small fonts more painful (I love small fonts and find that the ability to use smaller fonts is one of the main benefits of anti-aliasing). > I will be happy to write one. I assume the format to follow is used > in the ChangeLog file at the top of emacs' CVS tree? IIRC it's documented in the Emacs manual, but follow the examples in src/ChangeLog. Basically: use the present tense and active forms, capitals after the ":" and don't forget the terminating ".". Use C-x 4 a (from the locations in the source code or from the corresponding diff-mode buffer) to help you write the entries. Stefan