unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: cyd@stupidchicken.com, yamaoka@jpl.org, emacs-devel@gnu.org
Subject: Re: Slow Info startup
Date: Thu, 01 Dec 2005 23:47:54 +0200	[thread overview]
Message-ID: <878xv4h4l1.fsf@jurta.org> (raw)
In-Reply-To: <E1EhhZL-0002d2-BD@fencepost.gnu.org> (Richard M. Stallman's message of "Thu, 01 Dec 2005 01:05:23 -0500")

>     When you browse around, your Info history will be recorded as
>     though you are visiting the real "elisp" info file, at
>     /usr/share/info/elisp or wherever.  If you later visit the
>     "real" info file, those links will be fontified as "previously
>     visited" links.  Maybe that's an acceptable situation, however.
>
> Maybe it is acceptable, but first, could you explain why you think
> this is the best solution?
>
> Why is removing the directory related to making this code faster?

The Info history contains absolute file names.  Menu items and
cross-references contain only file names without directory part.
Info uses the history to decide how to fontify visited references:
if the file name (and node name) of a menu item or cross-reference
exists in the history then it is fontified with `info-xref-visited'.

The old code uses `file-name-nondirectory' to remove directory part
from absolute file names in the history before comparing them to the
name extracted from a menu item or cross-reference.  The new code uses
`Info-find-file' to find the absolute file name of a menu item
or cross-reference before comparing it to absolute file names in
the history.  `Info-find-file' is a quadratically slow function that
iterates over `Info-directory-list' and `Info-suffix-list' to find the
absolute Info file name.  The `dir' node usually contains hundreds of
menu items with non-absolute file names in parens, so `Info-find-file'
gets called on each of them during fontification in the new code.

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2005-12-01 21:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-30  1:40 Slow Info startup Katsumi Yamaoka
2005-11-30  2:38 ` Chong Yidong
2005-11-30  2:41   ` Chong Yidong
2005-11-30  2:48   ` Juri Linkov
2005-11-30  3:19   ` Katsumi Yamaoka
2005-12-01  6:05   ` Richard M. Stallman
2005-12-01 21:47     ` Juri Linkov [this message]
2005-12-01 22:46       ` Chong Yidong
2005-12-02  0:03         ` Juri Linkov
2005-12-02 18:21       ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878xv4h4l1.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).