unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: Wrong common substring highlighted in Completion buffer
Date: Mon, 12 Dec 2005 09:44:34 +0200	[thread overview]
Message-ID: <878xuqolmo.fsf@jurta.org> (raw)
In-Reply-To: <E1ElJMB-0003rY-Op@fencepost.gnu.org> (Richard M. Stallman's message of "Sun, 11 Dec 2005 00:02:43 -0500")

I also noticed that after using M-TAB in a Lisp buffer and selecting
a completion from the *Completion* buffer, highlighting from the
common substring is copied to the original buffer.  This can be fixed
by the following patch.

Index: lisp/simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.778
diff -c -r1.778 simple.el
*** lisp/simple.el	10 Dec 2005 01:12:25 -0000	1.778
--- lisp/simple.el	12 Dec 2005 07:43:55 -0000
***************
*** 4744,4750 ****
  	(error "No completion here"))
      (setq beg (previous-single-property-change beg 'mouse-face))
      (setq end (or (next-single-property-change end 'mouse-face) (point-max)))
!     (setq completion (buffer-substring beg end))
      (let ((owindow (selected-window)))
        (if (and (one-window-p t 'selected-frame)
  	       (window-dedicated-p (selected-window)))
--- 4744,4750 ----
  	(error "No completion here"))
      (setq beg (previous-single-property-change beg 'mouse-face))
      (setq end (or (next-single-property-change end 'mouse-face) (point-max)))
!     (setq completion (buffer-substring-no-properties beg end))
      (let ((owindow (selected-window)))
        (if (and (one-window-p t 'selected-frame)
  	       (window-dedicated-p (selected-window)))

-- 
Juri Linkov
http://www.jurta.org/emacs/

      parent reply	other threads:[~2005-12-12  7:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-10 10:14 Wrong common substring highlighted in Completion buffer Juri Linkov
2005-12-11  5:02 ` Richard M. Stallman
2005-12-12  7:43   ` Juri Linkov
2005-12-13  3:15     ` Richard M. Stallman
2005-12-14  7:59       ` Juri Linkov
2005-12-15  2:07         ` Richard M. Stallman
2005-12-12  7:44   ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878xuqolmo.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).