font-lock-warning-face

font-lock-warning-face

[Nick Roberts]

I use font-lock-warning-face in both gud.el and gdb-ui.el for things that I
want to draw the users attention to like errors and changed values.  Its
purpose is the opposite of 'shadow' and goes beyond font-lock.  Would it be a
good idea to create a new face (and from which font-lock-warning-face could
inherit) called `warning', say, and put it in faces.el so that font-lock
doesn't have to be loaded?

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: font-lock-warning-face

[Dan Nicolaescu]

Nick Roberts <nickrob@snap.net.nz> writes:

  > I use font-lock-warning-face in both gud.el and gdb-ui.el for things that I
  > want to draw the users attention to like errors and changed values.  Its
  > purpose is the opposite of 'shadow' and goes beyond font-lock.  Would it be a
  > good idea to create a new face (and from which font-lock-warning-face could
  > inherit) called `warning', say, and put it in faces.el so that font-lock
  > doesn't have to be loaded?

font-lock is always loaded nowadays, so no problem with that.

Re: font-lock-warning-face

[Nick Roberts]

 > font-lock is always loaded nowadays, so no problem with that.

OK, thanks.  I'm a bit surprised that global-font-lock-mode is enabled even
with -D (--basic-display), but I probably should have followed the thread.

There are quite a few file that still require font-lock, I don't know if
its were removing these requires.


-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: font-lock-warning-face

[Richard M. Stallman]

    I use font-lock-warning-face in both gud.el and gdb-ui.el for things that I
    want to draw the users attention to like errors and changed values.  Its
    purpose is the opposite of 'shadow' and goes beyond font-lock.  Would it be a
    good idea to create a new face (and from which font-lock-warning-face could
    inherit) called `warning', say, and put it in faces.el so that font-lock
    doesn't have to be loaded?

Maybe, but we would need to think about this somewhat more before
doing it.  What other uses would we want this to be used for?

Re: font-lock-warning-face

[Nick Roberts]

 >     I use font-lock-warning-face in both gud.el and gdb-ui.el for things
 >     that I want to draw the users attention to like errors and changed
 >     values.  Its purpose is the opposite of 'shadow' and goes beyond
 >     font-lock.  Would it be a good idea to create a new face (and from
 >     which font-lock-warning-face could inherit) called `warning', say, and
 >     put it in faces.el so that font-lock doesn't have to be loaded?
 > 
 > Maybe, but we would need to think about this somewhat more before
 > doing it.  What other uses would we want this to be used for?

Well I don't know how many you want, but additionally:

1) The face dired-marked inherits from it.
2) The face ido-incomplete-regexp inherits from it.
3) The face iswitchb-invalid-regexp inherits from it.
4) The face cvs-fi-conflict-face is an alias for it.
5) The face compilation-error inherits from it.

and presumably more uses for shadow have been found since it was created
(I use it for out of scope watch expressions for a start).

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: font-lock-warning-face

[Miles Bader]

Nick Roberts <nickrob@snap.net.nz> writes:
> > > Would it be a good idea to create a new face (and from which
> > > font-lock-warning-face could inherit) called `warning', say, and
> > > put it in faces.el so that font-lock doesn't have to be loaded?
>
>  > Maybe, but we would need to think about this somewhat more before
>  > doing it.  What other uses would we want this to be used for?
>
> 1) The face dired-marked inherits from it.
> 2) The face ido-incomplete-regexp inherits from it.
> 3) The face iswitchb-invalid-regexp inherits from it.
> 4) The face cvs-fi-conflict-face is an alias for it.
> 5) The face compilation-error inherits from it.

So how about a name like "emphasis" instead of warning?

Or alternatively, add _both_ "emphasis" and "warning", and by default
have warning inherit from emphasis (the idea being that users could make
"warning" more obnoxious if they wanted to, while "emphasis" would
continue to be more acceptable for normal usage).

-Miles
-- 
"Though they may have different meanings, the cries of 'Yeeeee-haw!' and
 'Allahu akbar!' are, in spirit, not actually all that different."

Re: font-lock-warning-face

[Nick Roberts]

 > So how about a name like "emphasis" instead of warning?
 > 
 > Or alternatively, add _both_ "emphasis" and "warning", and by default
 > have warning inherit from emphasis (the idea being that users could make
 > "warning" more obnoxious if they wanted to, while "emphasis" would
 > continue to be more acceptable for normal usage).

I was trying to keep things simple.  I think there should be at least one face
described in the node "Standard Faces" that complements shadow, and that
font-lock-warning-face seems to be currently serving that purpose.

If people want others, that's fine with me (for example the face
dired-warning inherits from font-lock-comment-face for more subdued
warning (= emphasis?)).

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: font-lock-warning-face

[Richard Stallman]

The idea of an `emphasis' font seems useful, and it is simple and safe
enough we could install it now.  But even that would require changes
in the manual.  So I think we should rather wait for after the release.
For now, let's fix bugs.

Re: font-lock-warning-face

[Juri Linkov]

> If people want others, that's fine with me (for example the face
> dired-warning inherits from font-lock-comment-face for more subdued
> warning (= emphasis?)).

Then what about the following three new faces:

`warning' - with colors of dired-warning and font-lock-comment-face
`error' - with colors of font-lock-warning-face
`emphasis' - inherit from bold

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: font-lock-warning-face

[Richard Stallman]

    `warning' - with colors of dired-warning and font-lock-comment-face
    `error' - with colors of font-lock-warning-face
    `emphasis' - inherit from bold

Adding three subtly different new general-purpose fonts is making
things rather complex.  I'd rather add just one (after the release).

Re: font-lock-warning-face

[Juri Linkov]

> So how about a name like "emphasis" instead of warning?
>
> Or alternatively, add _both_ "emphasis" and "warning", and by default
> have warning inherit from emphasis (the idea being that users could make
> "warning" more obnoxious if they wanted to, while "emphasis" would
> continue to be more acceptable for normal usage).

I think many faces that could inherit from `emphasis' (i.e. with the
purpose to make text more noticeable), now inherit from `bold'.
Example of such faces: completions-first-difference, buffer-menu-buffer,
comint-highlight-input,

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: font-lock-warning-face

[Juri Linkov]

>  > Maybe, but we would need to think about this somewhat more before
>  > doing it.  What other uses would we want this to be used for?
>
> Well I don't know how many you want, but additionally:
>
> 1) The face dired-marked inherits from it.
> 2) The face ido-incomplete-regexp inherits from it.
> 3) The face iswitchb-invalid-regexp inherits from it.
> 4) The face cvs-fi-conflict-face is an alias for it.
> 5) The face compilation-error inherits from it.

dired-marked is font-lock based face (used in `dired-font-lock-keywords').
compilation-error is indirectly font-lock based face as well (used via
`compilation-mode-font-lock-keywords').  So I think for these faces it is
appropriate to inherit from font-lock-warning-face.  Other faces have
nothing to do with font-lock-warning-face, so inheriting from a new face
`warning' would be good for easy customization.

-- 
Juri Linkov
http://www.jurta.org/emacs/