* url-http.el: Set cookies in the order they were sent.
@ 2007-03-31 23:42 Diane Murray
2007-04-01 0:38 ` Nick Roberts
2007-04-01 15:39 ` Chong Yidong
0 siblings, 2 replies; 3+ messages in thread
From: Diane Murray @ 2007-03-31 23:42 UTC (permalink / raw)
To: emacs-devel
In `url-http-handle-cookies', `mail-fetch-field' returns a list of
Set-Cookie headers in reverse, and the cookies are then set in that
order. This causes problems when a site tries to set the same cookie
more than once (with different values) in a single response, for
example, if a certain site "deletes" then sets the real value of some
session cookies all in one request.
This can be fixed by calling `reverse' on the list of cookies before
setting them.
2007-03-31 Diane Murray <disumu@x3y2z1.net>
* url-http.el (url-http-handle-cookies): Reverse the list returned
by `mail-fetch-field', so that cookies are set in the correct
order.
*** url-http.el 21 Mar 2007 18:39:05 +0100 1.50
--- url-http.el 01 Apr 2007 01:28:04 +0200
***************
*** 379,386 ****
"Handle all set-cookie / set-cookie2 headers in an HTTP response.
The buffer must already be narrowed to the headers, so `mail-fetch-field' will
work correctly."
! (let ((cookies (mail-fetch-field "Set-Cookie" nil nil t))
! (cookies2 (mail-fetch-field "Set-Cookie2" nil nil t)))
(and cookies (url-http-debug "Found %d Set-Cookie headers" (length cookies)))
(and cookies2 (url-http-debug "Found %d Set-Cookie2 headers" (length cookies2)))
(while cookies
--- 379,386 ----
"Handle all set-cookie / set-cookie2 headers in an HTTP response.
The buffer must already be narrowed to the headers, so `mail-fetch-field' will
work correctly."
! (let ((cookies (reverse (mail-fetch-field "Set-Cookie" nil nil t)))
! (cookies2 (reverse (mail-fetch-field "Set-Cookie2" nil nil t))))
(and cookies (url-http-debug "Found %d Set-Cookie headers" (length cookies)))
(and cookies2 (url-http-debug "Found %d Set-Cookie2 headers" (length cookies2)))
(while cookies
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-01 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-31 23:42 url-http.el: Set cookies in the order they were sent Diane Murray
2007-04-01 0:38 ` Nick Roberts
2007-04-01 15:39 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).