unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Diane Murray <disumu@x3y2z1.net>
To: emacs-devel@gnu.org
Subject: url-http.el: Set cookies in the order they were sent.
Date: Sun, 01 Apr 2007 01:42:13 +0200	[thread overview]
Message-ID: <878xddyo8a.fsf@x3y2z1.net> (raw)

In `url-http-handle-cookies', `mail-fetch-field' returns a list of
Set-Cookie headers in reverse, and the cookies are then set in that
order.  This causes problems when a site tries to set the same cookie
more than once (with different values) in a single response, for
example, if a certain site "deletes" then sets the real value of some
session cookies all in one request.

This can be fixed by calling `reverse' on the list of cookies before
setting them.


2007-03-31  Diane Murray  <disumu@x3y2z1.net>

	* url-http.el (url-http-handle-cookies): Reverse the list returned
	by `mail-fetch-field', so that cookies are set in the correct
	order.


*** url-http.el	21 Mar 2007 18:39:05 +0100	1.50
--- url-http.el	01 Apr 2007 01:28:04 +0200	
***************
*** 379,386 ****
    "Handle all set-cookie / set-cookie2 headers in an HTTP response.
  The buffer must already be narrowed to the headers, so `mail-fetch-field' will
  work correctly."
!   (let ((cookies (mail-fetch-field "Set-Cookie" nil nil t))
! 	(cookies2 (mail-fetch-field "Set-Cookie2" nil nil t)))
      (and cookies (url-http-debug "Found %d Set-Cookie headers" (length cookies)))
      (and cookies2 (url-http-debug "Found %d Set-Cookie2 headers" (length cookies2)))
      (while cookies
--- 379,386 ----
    "Handle all set-cookie / set-cookie2 headers in an HTTP response.
  The buffer must already be narrowed to the headers, so `mail-fetch-field' will
  work correctly."
!   (let ((cookies (reverse (mail-fetch-field "Set-Cookie" nil nil t)))
! 	(cookies2 (reverse (mail-fetch-field "Set-Cookie2" nil nil t))))
      (and cookies (url-http-debug "Found %d Set-Cookie headers" (length cookies)))
      (and cookies2 (url-http-debug "Found %d Set-Cookie2 headers" (length cookies2)))
      (while cookies

             reply	other threads:[~2007-03-31 23:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-31 23:42 Diane Murray [this message]
2007-04-01  0:38 ` url-http.el: Set cookies in the order they were sent Nick Roberts
2007-04-01 15:39 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878xddyo8a.fsf@x3y2z1.net \
    --to=disumu@x3y2z1.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).