about ido-completing-read and completing-read

about ido-completing-read and completing-read

[William Xu]

Hi all, 

I'm addicted to ido-completing-read. Hence i want to enable it whenever
possible. Although i've turned on ido-everywhere, there are still places
using completing-read, such as woman, bookmark-jump, perldoc, webjump,
imenu, etags, etc. I find myself is keeping modifying their source codes
to replace completing-read with ido-completing-read..

How about adding a new user option, like  `ido-really-everythere', that
does ido-completing-read wherever possible?

-- 
William

Re: about ido-completing-read and completing-read

[Juanma Barranquero]

On 5/31/07, William Xu <william.xwl@gmail.com> wrote:

> I find myself is keeping modifying their source codes
> to replace completing-read with ido-completing-read..

You could try this:

 (defvar *completing-read-recursive* nil)

 (defadvice completing-read (around my-completing-read activate compile)
   (if *completing-read-recursive*
       ad-do-it
     (let ((*completing-read-recursive* t))
       (ido-completing-read prompt collection predicate require-match
initial-input hist def))))

to see whether it helps.

             Juanma

Re: about ido-completing-read and completing-read

[William Xu]

"Juanma Barranquero" <lekktu@gmail.com> writes:

   On 5/31/07, William Xu <william.xwl@gmail.com> wrote:

   > I find myself is keeping modifying their source codes
   > to replace completing-read with ido-completing-read..

   You could try this:

   (defvar *completing-read-recursive* nil)

   (defadvice completing-read (around my-completing-read activate compile)
     (if *completing-read-recursive*
         ad-do-it
       (let ((*completing-read-recursive* t))
         (ido-completing-read prompt collection predicate require-match
   initial-input hist def))))

   to see whether it helps.

Hmm, this would break some things. For instance, describe-function will
fail now. Also, the `collection' parameter is different between
them, ido-completing-read only accepts lists.

-- 
William

Re: about ido-completing-read and completing-read

[Juanma Barranquero]

On 5/31/07, William Xu <william.xwl@gmail.com> wrote:

> Hmm, this would break some things. For instance, describe-function will
> fail now. Also, the `collection' parameter is different between
> them, ido-completing-read only accepts lists.

It was a starting point. You can special-case some things from the
advice, I suppose. Whether it is easier than modifying the source of
every package that uses completing-read or not, it's your call.

             Juanma