From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael@cadilhac.name (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Long standing warnings in C files. Date: Sun, 16 Sep 2007 16:49:00 +0200 Organization: Epita/LRDE Message-ID: <878x76fyxv.fsf@cadilhac.name> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1514036546==" X-Trace: sea.gmane.org 1189954312 11976 80.91.229.12 (16 Sep 2007 14:51:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 16 Sep 2007 14:51:52 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 16 16:51:49 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IWvTQ-0008T1-Ri for ged-emacs-devel@m.gmane.org; Sun, 16 Sep 2007 16:51:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IWvTP-0000Cv-NL for ged-emacs-devel@m.gmane.org; Sun, 16 Sep 2007 10:51:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IWvTM-0000Bb-5s for emacs-devel@gnu.org; Sun, 16 Sep 2007 10:51:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IWvTK-000090-I6 for emacs-devel@gnu.org; Sun, 16 Sep 2007 10:51:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IWvTK-00008a-Bt for emacs-devel@gnu.org; Sun, 16 Sep 2007 10:51:42 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IWvTJ-00037H-L8 for emacs-devel@gnu.org; Sun, 16 Sep 2007 10:51:42 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IWvSq-0002Pj-Co for emacs-devel@gnu.org; Sun, 16 Sep 2007 16:51:12 +0200 Original-Received: from ivr94-6-82-230-255-91.fbx.proxad.net ([82.230.255.91]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Sep 2007 16:51:12 +0200 Original-Received: from michael by ivr94-6-82-230-255-91.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Sep 2007 16:51:12 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 170 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: ivr94-6-82-230-255-91.fbx.proxad.net X-Website: http://michael.cadilhac.name Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAAYFBMVEUWCwUyFQk6JBNLGglQK BVRMiRkHQtwMBZuOCRyRi1iQiZyUUCFNxuIPCKRTC2mVTSpZTqVVS2SW0OYZkixb0qraE/KeU7EcT +4h2bPhVfQkm7hlnDkvZjYqIjrwJnzwqB5+4wZAAAACXBIWXMAAAsTAAALEwEAmpwYAAAACXZwQWc AAAAwAAAAMADO7oxXAAADvUlEQVRIx32Wi5ajIAyGRcCAchErVqu27/+W+wfbs724i3Mcz5n/S0JI wlTbyXrs+zrFEL1zPuIdY7xO6+PBf6u27f4DrFPO3jvoQYRYFoj9CXyu+7ZPEWrXUNM0zpEfgjuY9 RTY1hyg5qUNgMb44Dwiiz5OZ8DCwVCjpdLaGNOVtw+M+Lz+AlNwRAhGSamh1abrtFKmG0DkmL8BhE +GdCNlreChBaO7DpjpIvbv/fr4AnqErhoYF6KI4aPrLIeFQLGj6RO4JWLjtdZ1WQXhvegGG0EKyO/ vwH7xJBk4tLrW5UPxN3zAufHDO3Axh4MCMPLisKQyRuJo/Btw60gpWcu6OogjsmIeiRIKgUlj3oCp a1QtRP1ywT9VfXCiZMEg4X+BfYADAHhhdc+NV1UBBT9SIedvgFFwDFslkO7S8e+KtQcohJCyefdgt DoC4pe+FB8VL3bDeiGB/AVurZJCvY5AtdaSKpYLJArxCXCOlMUpiRpF0Sbb8nZYBnGBPoGZuOCGAd lTqgXRlrrDuUgpDh+VNPYN0IRALnkIFsVTiBanbBQbesYl1Num584iojnnHIPVJRSJvFnrrFHPmD6 yBKJVbZ+nKScjIVfatlSaJ9BBiIbcW1rnOSF4F/OYGiFLQaCXyAUsLTggnAN9VOuMaBtuX1QmHwok RD4CIHzXChG5z37oWkRhxx5tCmdKNUSp7/tUYlQwQ/6z424JPtr+mlwwwbbGQj5CXwBjyPj4NQRmJ J7GZez7mPpk02W+jvgMnFrUaozhE7jPF9va+QZinMaxn0dGMSy5ExuHmdZ8APf7felTv9zGccGal3 le2JdHt0lJaGklvjwA6JcVACwXpugd+gAJQvuIL2C7r9eJgQscXQH0I+sxkrBjjE0ukW9gui7rMo9 DAoGnTzyZceA8lYh+AMxWeFiu/ZhSLCeAUex4hhPr6XsPPAqu0xRxNVAaS0J58pODvhCN/AFWziLP rMtYjsxD6y0dDpDeH2Cf+sxEyPmSYuIJbOi1zCmQc/DkbQg2FQ/O2RfgDP0Aj8eU+VpDmlpLvBkqe kTJpe5+r6xtz9A7VnCxlthfAJkz4JGRJfzVcEiHHK36BOgE2PYRPpIna0K5wAzGCLcWN6A6A3CRRu SJWo+NoybQfag9TA/CxymwTdnDWkh4cPOweckTRCkhzgH8K+ChxkKG2L4oQBlPp8B2G/sc02CDKTp xXExlOJ3q79vcpyGYlmelFOXRxyj/hwe+XnBhw6osY17wJfB/IB/3o2a14Hl8jNfqDx44iLN4w0aG AAAAAElFTkSuQmCC User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) Cancel-Lock: sha1:8HFnF3+veOsOOQ3RPPj3Nz6+Ki8= X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:79039 Archived-At: --===============1514036546== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable There's some long-standing warnings in xterm.c and coding.c that we probably should get rid of. I don't think the following patch could break anything, but I prefer to ask. Warnings=A0: --=-=-= Content-Disposition: inline; filename=warnings.txt coding.c:4468: warning: passing argument 1 of 'detect_eol_type_in_2_octet_form' discards qualifiers from pointer target type coding.c:4471: warning: passing argument 1 of 'detect_eol_type_in_2_octet_form' discards qualifiers from pointer target type coding.c:4474: warning: passing argument 1 of 'detect_eol_type' discards qualifiers from pointer target type coding.c: In function 'detect_coding_system': coding.c:6603: warning: passing argument 1 of 'detect_eol_type' discards qualifiers from pointer target type xterm.c: In function 'handle_one_xevent': xterm.c:6644: warning: passing argument 2 of 'note_mouse_movement' from incompatible pointer type xterm.c:6677: warning: passing argument 2 of 'note_mouse_movement' from incompatible pointer type --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Patch=A0: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=warnings.patch Content-Transfer-Encoding: quoted-printable Index: xterm.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/xterm.c,v retrieving revision 1.957 diff -B -w -c -r1.957 xterm.c *** xterm.c 14 Sep 2007 04:11:26 -0000 1.957 =2D-- xterm.c 16 Sep 2007 14:48:44 -0000 *************** *** 6641,6647 **** /* We may get an EnterNotify on the buttons in the toolbar. In that case we moved out of any highlighted area and need to note this.= */ if (!f && last_mouse_glyph_frame) ! note_mouse_movement (last_mouse_glyph_frame, &event); #endif goto OTHER; =20=20 =2D-- 6641,6647 ---- /* We may get an EnterNotify on the buttons in the toolbar. In that case we moved out of any highlighted area and need to note this.= */ if (!f && last_mouse_glyph_frame) ! note_mouse_movement (last_mouse_glyph_frame, &event.xmotion); #endif goto OTHER; =20=20 *************** *** 6674,6680 **** #ifdef USE_GTK /* See comment in EnterNotify above */ else if (last_mouse_glyph_frame) ! note_mouse_movement (last_mouse_glyph_frame, &event); #endif goto OTHER; =20=20 =2D-- 6674,6680 ---- #ifdef USE_GTK /* See comment in EnterNotify above */ else if (last_mouse_glyph_frame) ! note_mouse_movement (last_mouse_glyph_frame, &event.xmotion); #endif goto OTHER; =20=20 Index: coding.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/coding.c,v retrieving revision 1.355 diff -B -w -c -r1.355 coding.c *** coding.c 29 Aug 2007 05:27:58 -0000 1.355 =2D-- coding.c 16 Sep 2007 14:48:47 -0000 *************** *** 4335,4344 **** =20=20 static int detect_eol_type (source, src_bytes, skip) ! unsigned char *source; int src_bytes, *skip; { ! unsigned char *src =3D source, *src_end =3D src + src_bytes; unsigned char c; int total =3D 0; /* How many end-of-lines are found so far. */ int eol_type =3D CODING_EOL_UNDECIDED; =2D-- 4335,4344 ---- =20=20 static int detect_eol_type (source, src_bytes, skip) ! const unsigned char *source; int src_bytes, *skip; { ! const unsigned char *src =3D source, *src_end =3D src + src_bytes; unsigned char c; int total =3D 0; /* How many end-of-lines are found so far. */ int eol_type =3D CODING_EOL_UNDECIDED; *************** *** 4384,4393 **** =20=20 static int detect_eol_type_in_2_octet_form (source, src_bytes, skip, big_endian_p) ! unsigned char *source; int src_bytes, *skip, big_endian_p; { ! unsigned char *src =3D source, *src_end =3D src + src_bytes; unsigned int c1, c2; int total =3D 0; /* How many end-of-lines are found so far. */ int eol_type =3D CODING_EOL_UNDECIDED; =2D-- 4384,4393 ---- =20=20 static int detect_eol_type_in_2_octet_form (source, src_bytes, skip, big_endian_p) ! const unsigned char *source; int src_bytes, *skip, big_endian_p; { ! const unsigned char *src =3D source, *src_end =3D src + src_bytes; unsigned int c1, c2; int total =3D 0; /* How many end-of-lines are found so far. */ int eol_type =3D CODING_EOL_UNDECIDED; --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable If no one complains, I'll install that in a few days. =2D-=20 | Micha=EBl `Micha' Cadilhac | I am very sad for you = | | http://michael.cadilhac.name | that you are running = | | JID/MSN: | Windows Vista. = | `---- michael.cadilhac@gmail.com | -- RMS - = --' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.2 (GNU/Linux) iD8DBQFG7UJgUJhDmOfFA3URAq6VAJsGpdQGCt1T4tkgxfxZz0vhirykjQCg2aRx MYGwXY9RJhD1sq7IiPHu/b0= =JkPV -----END PGP SIGNATURE----- --==-=-=-- --===============1514036546== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1514036546==--