From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Magnus Henoch Newsgroups: gmane.emacs.devel Subject: Re: Change branch for HTTP chunking bug? Date: Tue, 11 Mar 2008 13:19:39 +0100 Message-ID: <878x0pxxk4.fsf@freemail.hu> References: <87d4q2ua78.fsf@freemail.hu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205238021 10802 80.91.229.12 (11 Mar 2008 12:20:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Mar 2008 12:20:21 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 11 13:20:49 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JZ3TI-0001lj-Is for ged-emacs-devel@m.gmane.org; Tue, 11 Mar 2008 13:20:44 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JZ3Sj-00023n-Kx for ged-emacs-devel@m.gmane.org; Tue, 11 Mar 2008 08:20:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JZ3Sf-00023Q-R6 for emacs-devel@gnu.org; Tue, 11 Mar 2008 08:20:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JZ3Sb-000234-QA for emacs-devel@gnu.org; Tue, 11 Mar 2008 08:20:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JZ3Sb-000231-M8 for emacs-devel@gnu.org; Tue, 11 Mar 2008 08:20:01 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JZ3Sb-0005Mi-2l for emacs-devel@gnu.org; Tue, 11 Mar 2008 08:20:01 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JZ3SN-0004HB-Ie for emacs-devel@gnu.org; Tue, 11 Mar 2008 12:19:47 +0000 Original-Received: from etthundrat.olf.sgsnet.se ([193.11.222.85]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Mar 2008 12:19:47 +0000 Original-Received: from mange by etthundrat.olf.sgsnet.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Mar 2008 12:19:47 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 22 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: etthundrat.olf.sgsnet.se Mail-Copies-To: never Jabber-Id: legoscia@jabber.cd.chalmers.se User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) Cancel-Lock: sha1:5nOR7JFc+DQyptml3XgCHUdMHHE= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92149 Archived-At: Stefan Monnier writes: > It seems that the bug is also present on the 22 branch. I'm not sure > how serious it is compared to the risk of introducing more bugs. > How confident are you that this is the right fix Quite confident; the previous code didn't do what the standard spells out, but with my fix it does. I have also tested it with downloads from Emacswiki. > and that it will not break anything currently working? It eats whitespace at a point where it isn't significant, so nothing should break. [It would be nice if there were a test suite for the URL package. It seems to be that the easiest way to implement that would be if it were possible to make pipes (as in the system call) that behave as pairs of Lisp processes, so that the test suite can perform a fake conversation with the client code...] Magnus