From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: binding c-h in isearch Date: Sun, 20 Apr 2008 01:49:55 +0300 Organization: JURTA Message-ID: <878wz931f0.fsf@jurta.org> References: <87d4oom6fm.fsf@jurta.org> <87fxthd8hk.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208646870 14133 80.91.229.12 (19 Apr 2008 23:14:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Apr 2008 23:14:30 +0000 (UTC) Cc: joakim@verona.se, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 20 01:15:04 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JnMGt-0003Dw-FE for ged-emacs-devel@m.gmane.org; Sun, 20 Apr 2008 01:15:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnMGE-0004fE-8g for ged-emacs-devel@m.gmane.org; Sat, 19 Apr 2008 19:14:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JnMEm-0003Qm-1o for emacs-devel@gnu.org; Sat, 19 Apr 2008 19:12:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JnMEj-0003PB-Jb for emacs-devel@gnu.org; Sat, 19 Apr 2008 19:12:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnMEj-0003P2-DR for emacs-devel@gnu.org; Sat, 19 Apr 2008 19:12:49 -0400 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JnMEi-0003pp-K3 for emacs-devel@gnu.org; Sat, 19 Apr 2008 19:12:48 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JnMEf-0002YR-8Q; Sun, 20 Apr 2008 02:12:45 +0300 In-Reply-To: (Stefan Monnier's message of "Sat, 19 Apr 2008 16:57:35 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: d0b3bc0b24c4067239780ad28ae5b444 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2676 [Apr 18 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 10 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95491 Archived-At: >> window. So it is necessary to bind `same-window-buffer-names' and >> `same-window-regexps' to nil temporarily to force displaying the Help >> buffer in another window. > > That works around the problem but doesn't fix it. You can specify > `same-window' in special-display-regexp, for example. Or you could > encounter similar problems by setting display-buffer-function, etc... > A real fix is to make sure we return to the proper window and buffer > when we get back to the main search loop. Currently I see no place in the main search loop to do this, and implementing this properly would add too much complexity to already very complex isearch mode. So if this works in 99% cases, I think this wourkaround would be ok. >> + (while (< i 256) >> + (define-key map (vector i) 'isearch-other-control-char) >> + (setq i (1+ i))) > > This doesn't look right. You probably just want to use > > (define-key map [t] 'isearch-other-control-char) I tested this, and it works correctly. Thanks for the hint. -- Juri Linkov http://www.jurta.org/emacs/