unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: joakim@verona.se, emacs-devel@gnu.org
Subject: Re: binding c-h in isearch
Date: Sun, 20 Apr 2008 01:49:55 +0300	[thread overview]
Message-ID: <878wz931f0.fsf@jurta.org> (raw)
In-Reply-To: <jwvfxth5zwn.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 19 Apr 2008 16:57:35 -0400")

>> window.  So it is necessary to bind `same-window-buffer-names' and
>> `same-window-regexps' to nil temporarily to force displaying the Help
>> buffer in another window.
>
> That works around the problem but doesn't fix it.  You can specify
> `same-window' in special-display-regexp, for example.  Or you could
> encounter similar problems by setting display-buffer-function, etc...
> A real fix is to make sure we return to the proper window and buffer
> when we get back to the main search loop.

Currently I see no place in the main search loop to do this,
and implementing this properly would add too much complexity
to already very complex isearch mode.  So if this works in 99%
cases, I think this wourkaround would be ok.

>> +     (while (< i 256)
>> +       (define-key map (vector i) 'isearch-other-control-char)
>> +       (setq i (1+ i)))
>
> This doesn't look right.  You probably just want to use
>
>        (define-key map [t] 'isearch-other-control-char)

I tested this, and it works correctly.  Thanks for the hint.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2008-04-19 22:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-16 12:10 binding c-h in isearch joakim
2008-04-16 13:30 ` Lennart Borgman (gmail)
2008-04-16 22:35   ` Lennart Borgman (gmail)
2008-04-16 15:28 ` Stefan Monnier
2008-04-16 17:44   ` Paul R
2008-04-17 19:25   ` joakim
2008-04-17 23:14   ` Juri Linkov
2008-04-18  0:42     ` Stefan Monnier
2008-04-19 20:07       ` Juri Linkov
2008-04-19 20:49         ` Lennart Borgman (gmail)
2008-04-19 22:52           ` Juri Linkov
2008-04-20  0:53             ` Lennart Borgman (gmail)
2008-04-20 23:51               ` Juri Linkov
2008-04-21  0:13                 ` Lennart Borgman (gmail)
2008-04-19 20:57         ` Stefan Monnier
2008-04-19 22:49           ` Juri Linkov [this message]
2008-04-18 10:59     ` Johan Bockgård
2008-04-19 21:20   ` Drew Adams
2008-04-19 21:49     ` Stefan Monnier
2008-04-19 22:39       ` Drew Adams
2008-04-19 22:59     ` Juri Linkov
2008-04-19 23:39       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wz931f0.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=joakim@verona.se \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).