Can ad-do-it be used in a function called from the defadvice code?

Can ad-do-it be used in a function called from the defadvice code?

[Lennart Borgman]

See subject line.

Re: Can ad-do-it be used in a function called from the defadvice code?

[Davis Herring]

Of course not.  It's not a macro, since you don't call it like a function.
 It can't be a variable, because that couldn't trigger evaluation of the
advised function.  So it must be something magical that defadvice itself
looks for.  It can't see into the functions you're calling -- not without
a truly ridiculous amount of instrumentation and overhead -- so it can't
make ad-do-it magic anywhere else.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: Can ad-do-it be used in a function called from the defadvice code?

[Lennart Borgman]

On Wed, Jul 1, 2009 at 6:02 PM, Davis Herring<herring@lanl.gov> wrote:
> Of course not.  It's not a macro, since you don't call it like a function.
>  It can't be a variable, because that couldn't trigger evaluation of the
> advised function.  So it must be something magical that defadvice itself
> looks for.  It can't see into the functions you're calling -- not without
> a truly ridiculous amount of instrumentation and overhead -- so it can't
> make ad-do-it magic anywhere else.

Thanks Davis, but maybe you are right that it is hard to implement,
but on the other hand can't ad-do-it be left as a placeholder where
the correct function is called when needed. It does not seem to be
very much overhead to me since the let-binding structure is already
there and probably can be used with some mangling.

But anyway I beleive you are right about how it is implemented now (so
I wll copy some code instead...)

Re: Can ad-do-it be used in a function called from the defadvice code?

[Stephen J. Turnbull]

Lennart Borgman writes:

 > Thanks Davis, but maybe you are right that it is hard to implement,
 > but on the other hand can't ad-do-it be left as a placeholder where
 > the correct function is called when needed. It does not seem to be
 > very much overhead to me since the let-binding structure is already
 > there and probably can be used with some mangling.

And what do you do if there are multiple pieces of advice active?
Which original function does is the "correct function" that this
particular 'ad-do-it refers to?

Re: Can ad-do-it be used in a function called from the defadvice code?

[Lennart Borgman]

On Wed, Jul 1, 2009 at 6:48 PM, Stephen J. Turnbull<stephen@xemacs.org> wrote:
> Lennart Borgman writes:
>
>  > Thanks Davis, but maybe you are right that it is hard to implement,
>  > but on the other hand can't ad-do-it be left as a placeholder where
>  > the correct function is called when needed. It does not seem to be
>  > very much overhead to me since the let-binding structure is already
>  > there and probably can be used with some mangling.
>
> And what do you do if there are multiple pieces of advice active?
> Which original function does is the "correct function" that this
> particular 'ad-do-it refers to?

The innermost I guess. But maybe that could lead to ambiguities too? I
am not sure.