From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Tue, 03 May 2011 20:56:35 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <878vundy98.fsf@lifelogs.com> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87bp11imgb.wl%claudio.bley@gmail.com> <8739mc5nes.fsf@lifelogs.com> <87ipuubao6.fsf@lifelogs.com> <87fwpjfkkz.fsf@lifelogs.com> <87bp072fb1.fsf@lifelogs.com> <874o5vimm5.fsf@lifelogs.com> <87zknjmcyk.fsf@lifelogs.com> <87sjta2zvp.fsf@lifelogs.com> <87liyzglkh.fsf@lifelogs.com> <4DB77682.1070605@gmail.com> <8762q04ba1.fsf@lifelogs.com> <87hb9dufao.fsf@lifelogs.com> <87d3jzc0ct.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304474214 913 80.91.229.12 (4 May 2011 01:56:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 May 2011 01:56:54 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 04 03:56:51 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QHRKc-0003Rf-ID for ged-emacs-devel@m.gmane.org; Wed, 04 May 2011 03:56:50 +0200 Original-Received: from localhost ([::1]:60881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHRKb-0001lF-U1 for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 21:56:49 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHRKa-0001lA-5o for emacs-devel@gnu.org; Tue, 03 May 2011 21:56:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHRKZ-0000e0-5Z for emacs-devel@gnu.org; Tue, 03 May 2011 21:56:48 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:51542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHRKY-0000dw-NE for emacs-devel@gnu.org; Tue, 03 May 2011 21:56:47 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QHRKX-0003Pl-Em for emacs-devel@gnu.org; Wed, 04 May 2011 03:56:45 +0200 Original-Received: from c-67-186-102-106.hsd1.il.comcast.net ([67.186.102.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 May 2011 03:56:45 +0200 Original-Received: from tzz by c-67-186-102-106.hsd1.il.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 May 2011 03:56:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-67-186-102-106.hsd1.il.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:B1e05Iym/bSSbmsQr8BgA0zCrsI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139092 Archived-At: On Wed, 4 May 2011 03:30:23 +0200 Juanma Barranquero wrote: JB> 2011/5/3 Ted Zlatanov : >> The else block above should log things at level 1, I think, since it's a >> rare event and important to know: >> >> CHECK_STRING (Qgnutls_dll); >> GNUTLS_LOG2 (1, max_log_level, "loading the GnuTLS DLL: ", SSDATA (Qgnutls_dll)); JB> Qgnutls_dll is not really the file name, but just the symbol `gnutls'. JB> The file name is not known outside of w32_delayed_load, so it can't JB> really be used in the message. Could you push it into the :dll property of that symbol (always a list)? Then just loop on all the names when logging later. JB> I thought of adding GNUTLS_LOG (1, max_log_level, "..."), but isn't JB> GnuTLS required to be able to compute max_log_level? If so, it can JB> only be used to log a successful load, and then its place is really in JB> Fgnutls_boot, not Fgnutls_available_p. You could just say GNUTLS_LOG2 (1, 1, "loading the GnuTLS DLL: ", filename) so it's unconditional (not the end of the world) or use the int value of `gnutls-log-level' directly from gnutls.el... Either way is fine with me, but logging the file name is IMO important if possible. If not just use GNUTLS_LOG as you say. JB> Attached is the new patch, which is like the previous one, with the JB> changes requested by Eli and a clarification in nt/INSTALL. I think it JB> is ready to install once we settle on the issue of GNUTLS_LOG. Thanks so much! Ted