From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marco Pessotto Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] rcirc: support TLS/SSL and arbitrary connection method Date: Tue, 31 May 2011 13:16:29 +0200 Message-ID: <878vtnqfw2.fsf@universe.krase.net> References: <87fwnvvp3d.fsf@universe.krase.net> <877h97p52j.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1306840618 5388 80.91.229.12 (31 May 2011 11:16:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 May 2011 11:16:58 +0000 (UTC) Cc: Ted Zlatanov , rcyeske@gmail.com To: Emacs Development Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 31 13:16:51 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QRMwM-0000lO-7i for ged-emacs-devel@m.gmane.org; Tue, 31 May 2011 13:16:50 +0200 Original-Received: from localhost ([::1]:59935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRMwL-0005hp-Pk for ged-emacs-devel@m.gmane.org; Tue, 31 May 2011 07:16:49 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRMwF-0005fX-Mm for emacs-devel@gnu.org; Tue, 31 May 2011 07:16:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRMwB-0002wv-Cy for emacs-devel@gnu.org; Tue, 31 May 2011 07:16:43 -0400 Original-Received: from mail-fx0-f41.google.com ([209.85.161.41]:43459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRMwB-0002wo-72 for emacs-devel@gnu.org; Tue, 31 May 2011 07:16:39 -0400 Original-Received: by fxm18 with SMTP id 18so3593548fxm.0 for ; Tue, 31 May 2011 04:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=R40tXzMFhzboiZCirl+iFiI8EF99+l+/PWeTzOKA8s4=; b=hmP8XyWtINkpnouBOzMK1eRyjdQlf0OViIn4NovUuGvQiQxBsYD9OdHEcH4EtvwusK OrpR4VsuPO/uicqynEmotT6Sb7lDoWfuHf/jhC4VOn9Y8uX/B1vIkuaL0cmihzInen0k Lqce0b+0qCtsC9DgRcg94xnaz6fAq17N5GhkM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=b0cT3cnUPFj6KfyYgt1raT8rqoRhAQgk88M0t5e5dg8+JQgcmY/wdbmuPhxLc9Q1MP 3re1q1IiWkb8Vxlk3+ekOcj/AiA2yW58tF9xBd/IcsD5D0Hp2GUbyXHKjY2R3NAFb2e9 Fa7jNdkYrU5zN6niGZgqKh54SvmWGJwwmmC5o= Original-Received: by 10.223.85.155 with SMTP id o27mr6647239fal.109.1306840598400; Tue, 31 May 2011 04:16:38 -0700 (PDT) Original-Received: from localhost (93-137-173-231.adsl.net.t-com.hr [93.137.173.231]) by mx.google.com with ESMTPS id q14sm1071759faa.3.2011.05.31.04.16.36 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2011 04:16:37 -0700 (PDT) In-Reply-To: <877h97p52j.fsf@lifelogs.com> (Ted Zlatanov's message of "Tue, 31 May 2011 04:55:32 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139957 Archived-At: Ted Zlatanov writes: > On Mon, 30 May 2011 23:46:30 +0200 Marco Pessotto wrote: > > MP> I'm writing you to submit a patch for rcirc.el to give it support for > MP> SSL connections. > ... > MP> +(require 'tls) > ... > MP> + (if use-tls > MP> + (setq process (open-tls-stream server nil server port-number)) > MP> + (setq process (open-network-stream server nil server port-number)))) > > Recent trunk versions of Emacs have an `open-network-stream' that > supports the built-in GnuTLS code directly. That's much better than > `open-tls-stream'. Could you look at that and maybe use it? Well, I looked at the trunk and the encryption thing is already there, starting from rev 104199. So you can trash the patch, which is meant for the 23.x branch, and close the "bug". I've updated the emacs wiki page with (hopefully) the correct informations: http://www.emacswiki.org/emacs/rcirc#toc4 And sorry for the noise. Cheers -- Marco