Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107140: * doc.c (store_function_docstring): Avoid applying docstring of alias to base function.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107140: * doc.c (store_function_docstring): Avoid applying docstring of alias to base function.

[Juanma Barranquero]

On Mon, Feb 6, 2012 at 14:43, Chong Yidong <cyd@gnu.org> wrote:

> -store_function_docstring (Lisp_Object fun, EMACS_INT offset)
> +store_function_docstring (Lisp_Object sym, EMACS_INT offset)
>  /* Use EMACS_INT because we get offset from pointer subtraction.  */
>  {
> -  fun = indirect_function (fun);
> +  /* Don't use indirect_function here, or defaliases will apply their
> +     docstrings to the base functions (Bug#2603).  */
> +  Lisp_Object fun = XSYMBOL (sym)->function;

I get a crash in temacs while recompiling.

    Juanma


Program received signal SIGTRAP, Trace/breakpoint trap.
[Switching to Thread 4536.0x1038]
0x76a6280d in KERNELBASE!DeleteAce () from C:\Windows\syswow64\KernelBase.dll
(gdb) bt
#0  0x76a6280d in KERNELBASE!DeleteAce () from
C:\Windows\syswow64\KernelBase.dll
#1  0x0114efce in w32_abort () at w32fns.c:7210
#2  0x01042190 in die (msg=0x15397e8 "assertion failed: SYMBOLP
(sym)", file=0x1539560 "doc.c", line=510) at alloc.c:6310
#3  0x010fb0e2 in store_function_docstring (sym=19983141,
offset=651477) at doc.c:510
#4  0x010fb314 in store_function_docstring (sym=54902266,
offset=651477) at doc.c:535
#5  0x010fba6b in Fsnarf_documentation (filename=54820865) at doc.c:681
#6  0x01034d7a in eval_sub (form=59208342) at eval.c:2335
#7  0x010301ee in Fprogn (args=59208310) at eval.c:358
#8  0x010321e7 in Flet (args=59222302) at eval.c:1105
#9  0x01034965 in eval_sub (form=59222342) at eval.c:2283
#10 0x01030060 in Fif (args=59222350) at eval.c:308
#11 0x01034965 in eval_sub (form=59222542) at eval.c:2283
#12 0x010855a2 in readevalloop (readcharfun=54786674,
stream=0x76232960, sourcename=54821473, printflag=0, unibyte=54704154,
readfun=54704154,
    start=54704154, end=54704154) at lread.c:1838
#13 0x010836b7 in Fload (file=54821297, noerror=54704154,
nomessage=54704154, nosuffix=54704154, must_suffix=54704154) at
lread.c:1316
#14 0x01034f5e in eval_sub (form=54687718) at eval.c:2349
#15 0x0103450e in Feval (form=54687718, lexical=54704154) at eval.c:2189
#16 0x0100532a in top_level_2 () at keyboard.c:1168
#17 0x01032beb in internal_condition_case (bfun=0x100530d
<top_level_2>, handlers=54761882, hfun=0x1004eba <cmd_error>) at
eval.c:1500
#18 0x0100535e in top_level_1 (ignore=54704154) at keyboard.c:1176
#19 0x0103260e in internal_catch (tag=54759906, func=0x100532c
<top_level_1>, arg=54704154) at eval.c:1257
#20 0x01005294 in command_loop () at keyboard.c:1131
#21 0x0100488f in recursive_edit_1 () at keyboard.c:758
#22 0x01004baa in Frecursive_edit () at keyboard.c:822
#23 0x010028b5 in main (argc=5, argv=0xa62b08) at emacs.c:1715

Lisp Backtrace:
"Snarf-documentation" (0x88f234)
"let" (0x88f44c)
"if" (0x88f56c)
"load" (0x88fb94)
(gdb) frame 3
#3  0x010fb0e2 in store_function_docstring (sym=19983141,
offset=651477) at doc.c:510
510       Lisp_Object fun = XSYMBOL (sym)->function;
(gdb) p sym
$1 = 19983141
(gdb) xtype
Lisp_Vectorlike
PVEC_COMPILED
(gdb)

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107140: * doc.c (store_function_docstring): Avoid applying docstring of alias to base function.

[Chong Yidong]

Juanma Barranquero <lekktu@gmail.com> writes:

> I get a crash in temacs while recompiling.

I've committed a patch that should fix this.  Thanks.