From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Olivier Sirven Newsgroups: gmane.emacs.devel Subject: Re: Patch for PHP5 support for etags Date: Mon, 12 Mar 2012 15:25:41 +0100 Message-ID: <878vj5x5ei.fsf@gandalf.home.thebuble.org> References: <87obsomsbt.fsf@gandalf.home.thebuble.org> <87399jjund.fsf@gandalf.home.thebuble.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1331563396 26743 80.91.229.3 (12 Mar 2012 14:43:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Mar 2012 14:43:16 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 12 15:43:15 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S76Su-0002gt-5R for ged-emacs-devel@m.gmane.org; Mon, 12 Mar 2012 15:43:12 +0100 Original-Received: from localhost ([::1]:58571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S76CP-0005RU-LA for ged-emacs-devel@m.gmane.org; Mon, 12 Mar 2012 10:26:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S76CH-0005Qw-T9 for emacs-devel@gnu.org; Mon, 12 Mar 2012 10:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S76CB-0002TW-BJ for emacs-devel@gnu.org; Mon, 12 Mar 2012 10:26:01 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:44351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S76CB-0002T8-1D for emacs-devel@gnu.org; Mon, 12 Mar 2012 10:25:55 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S76C8-0000Z0-1g for emacs-devel@gnu.org; Mon, 12 Mar 2012 15:25:52 +0100 Original-Received: from home.thebuble.org ([88.160.208.28]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 12 Mar 2012 15:25:51 +0100 Original-Received: from the.slaa by home.thebuble.org with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 12 Mar 2012 15:25:51 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 77 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: home.thebuble.org User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.0.94 (gnu/linux) Cancel-Lock: sha1:WW5P1+YdJBxB7jOpbg7ryggPc7w= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148975 Archived-At: Hi, On 2012-03-08 20:10:25, Francesco Potort́ wrote: >>On 2012-02-24 11:36:06, Olivier Sirven wrote: >>> On 2011-04-26 14:36:35, Lennart Borgman wrote: >>>> On Tue, Apr 26, 2011 at 2:25 PM, Francesco Potort́ wrote: >>>>> >>>>> Yes, I applied the patch.  I tested it and got strange results.  So I >>>>> need a php5 source file together with the expected results, so that I >>>>> can check it with more confidence.  Can you provide that, or point me to >>>>> someone else who can? >>>> >>>> Maybe some of those that have contributed to php-mode.el can? >>> >>> I'm no php-mode.el contributor but I do code in PHP5 every single >>> working day using emacs for a long time now. >>> I was previously forcing language detection to java in order to have >>> something usable even though not perfect. >>> >>> I've just found out about this PHP5 patch for etags and just gave it a >>> try. As far as I can see it works just fine, all my declarations are >>> there and I don't see any strange results. >>> >>> If you need any help getting this into the main code base I'd be glad to >>> help. But first I need to understand what you mean by "strange results" >>> so I can check whether or not I do have the same issue > > Ok, I must have lost this mail of yours, at least I cannot find it in my > records. Sorry about that. That said, I am lagging behind with work on > etags. Much, much behind. And yes, if some other maintainer steps in > to volunteer, I will pass the baton. > > Today I tried to recompile etags locally for the first time in a couple > years at least and I am seeing some problems (etags should be able to > compile even outside of the Emacs tree). ,----[ make etags ] | $ make etags | gcc -std=gnu99 -Wimplicit-function-declaration -Wold-style-definition -Wdeclaration-after-statement -DHAVE_CONFIG_H -I. -I../src -I../lib -I/home/slaanesh/src/emacs/trunk/lib-src -I/home/slaanesh/src/emacs/trunk/lib-src/../src -I/home/slaanesh/src/emacs/trunk/lib-src/../lib -g -O2 -DEMACS_NAME="\"GNU Emacs\"" \ | -DVERSION="\"24.0.94\"" /home/slaanesh/src/emacs/trunk/lib-src/etags.c \ | regex.o ../lib/libgnu.a -o etags | /tmp/cceEvudD.o: In function `main': | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1191: undefined reference to `rpl_optarg' | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1166: undefined reference to `rpl_optarg' | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1166: undefined reference to `rpl_optarg' | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1170: undefined reference to `rpl_optarg' | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1147: undefined reference to `rpl_optarg' | /tmp/cceEvudD.o:/home/slaanesh/src/emacs/trunk/lib-src/etags.c:1114: more undefined references to `rpl_optarg' follow | /tmp/cceEvudD.o: In function `main': | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1208: undefined reference to `rpl_optind' | /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1208: undefined reference to `rpl_optind' | ../lib/libgnu.a(getopt1.o): In function `rpl_getopt_long': | /home/slaanesh/src/emacs/trunk/lib/getopt1.c:43: undefined reference to `rpl_getopt_internal' | ../lib/libgnu.a(getopt1.o): In function `rpl_getopt_long_only': | /home/slaanesh/src/emacs/trunk/lib/getopt1.c:66: undefined reference to `rpl_getopt_internal' | collect2: ld returned 1 exit status | make: *** [etags] Error 1 `---- it seems etags compilation is broken even in the emacs tree (using a up-to-date bzr tree). Am I doing something wrong here? >>I see nobody has interest into PHP5 for etags...so sad! >> >>So maybe I'm the only one but what can/should I do to get this patch >>merged? > > If you would like to try, you are welcome! As a start, please try and > start from the current etags.c version in Emacs trunk. Then write to > me, I'll try to help you get going, if necessary. > > Else, I'll try to reapply the patch and see what comes out. Would be my pleasure to do it for sure :) -- Oliv