unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/emacs-24 r111116: eval-after-load fix
Date: Thu, 03 Jan 2013 05:27:19 +0400	[thread overview]
Message-ID: <878v8b839k.fsf@yandex.ru> (raw)
In-Reply-To: <E1TqZR5-0007qr-6Z@vcs.savannah.gnu.org> (Glenn Morris's message of "Wed, 02 Jan 2013 16:50:35 -0800")

I wonder, wouldn't it still make sense to purecopy the form, just not
the list wrapping it?

Glenn Morris <rgm@gnu.org> writes:
> ------------------------------------------------------------
> revno: 111116
> fixes bug: http://debbugs.gnu.org/13331
> committer: Glenn Morris <rgm@gnu.org>
> branch nick: emacs-24
> timestamp: Wed 2013-01-02 16:50:35 -0800
> message:
>   eval-after-load fix
>   
>   * lisp/subr.el (eval-after-load): Don't purecopy the form, so that it
>   can be nconc'd later on; reverts 2009-11-11 change.
> modified:
>   lisp/ChangeLog
>   lisp/subr.el
> === modified file 'lisp/ChangeLog'
> --- a/lisp/ChangeLog	2013-01-03 00:43:46 +0000
> +++ b/lisp/ChangeLog	2013-01-03 00:50:35 +0000
> @@ -1,5 +1,8 @@
>  2013-01-03  Glenn Morris  <rgm@gnu.org>
>  
> +	* subr.el (eval-after-load): Don't purecopy the form, so that it
> +	can be nconc'd later on; reverts 2009-11-11 change.  (Bug#13331)
> +
>  	* emacs-lisp/byte-run.el (defun): Place cl declarations
>  	after any interactive spec.  (Bug#13265)
>  
>
> === modified file 'lisp/subr.el'
> --- a/lisp/subr.el	2013-01-01 09:11:05 +0000
> +++ b/lisp/subr.el	2013-01-03 00:50:35 +0000
> @@ -1877,7 +1877,7 @@
>  		 ,form)))
>        ;; Add FORM to the element unless it's already there.
>        (unless (member form (cdr elt))
> -	(nconc elt (purecopy (list form)))))))
> +	(nconc elt (list form))))))
>  
>  (defvar after-load-functions nil
>    "Special hook run after loading a file.



       reply	other threads:[~2013-01-03  1:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1TqZR5-0007qr-6Z@vcs.savannah.gnu.org>
2013-01-03  1:27 ` Dmitry Gutov [this message]
2013-01-03  1:38   ` /srv/bzr/emacs/emacs-24 r111116: eval-after-load fix Glenn Morris
2013-01-03  3:27     ` Stephen J. Turnbull
2013-01-04  5:34       ` Dmitry Gutov
2013-01-04 10:58         ` Stephen J. Turnbull
2013-01-04 18:10           ` Stefan Monnier
2013-01-04 22:32             ` Dmitry Gutov
2013-01-05  2:54             ` Stephen J. Turnbull
2013-01-04  5:32     ` Dmitry Gutov
2013-01-04  9:39       ` Andreas Schwab
2013-01-04 10:41         ` joakim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v8b839k.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).