From: Mark Oteiza <mvoteiza@udel.edu>
To: emacs-devel@gnu.org
Subject: [PATCH] Remove special requirement to disable startup message.
Date: Sat, 19 Dec 2015 17:51:03 -0500 [thread overview]
Message-ID: <878u4qdpd4.fsf@udel.edu> (raw)
* lisp/startup.el (inhibit-startup-echo-area-message): Replace custom
string with t.
(display-startup-echo-area-message): Only check if
inhibit-startup-echo-area-message is truthy.
---
After seeing a commentary on the variable here:
http://emacshorrors.com/posts/advertising-your-freedom.html
and reading bug#13208 and bug#12370, I am inclined to change this
behavior. Not only is the checking mechanism in
`display-startup-echo-area-message' naïve and error-prone (see
bug#13208), but it does nothing to stop the site from disabling the
message, which is the only tangible justification (found in bug#12730)
for the special treatment to exist. It is trivial for site-start.el,
default.el, or init.el to contain
(defun display-startup-echo-area-message () nil)
or similar to disable the message for all users (example from bug#13208).
lisp/startup.el | 41 ++++-------------------------------------
1 file changed, 4 insertions(+), 37 deletions(-)
diff --git a/lisp/startup.el b/lisp/startup.el
index 1346310..0d3b44a 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -76,21 +76,10 @@ once you are familiar with the contents of the startup screen."
(defvar startup-screen-inhibit-startup-screen nil)
-;; FIXME? Why does this get such weirdly extreme treatment, when the
-;; more important inhibit-startup-screen does not.
(defcustom inhibit-startup-echo-area-message nil
- "Non-nil inhibits the initial startup echo area message.
-Setting this variable takes effect
-only if you do it with the customization buffer
-or if your init file contains a line of this form:
- (setq inhibit-startup-echo-area-message \"YOUR-USER-NAME\")
-If your init file is byte-compiled, use the following form
-instead:
- (eval \\='(setq inhibit-startup-echo-area-message \"YOUR-USER-NAME\"))
-Thus, someone else using a copy of your init file will see the
-startup message unless he personally acts to inhibit it."
- :type '(choice (const :tag "Don't inhibit")
- (string :tag "Enter your user name, to inhibit"))
+ "Non-nil inhibits the initial startup echo area message."
+ :type '(choice (const :tag "Don't inhibit" nil)
+ (const :tag "Inhibit" t))
:group 'initialization)
(defcustom inhibit-default-init nil
@@ -2154,29 +2143,7 @@ Type \\[describe-distribution] for information on "))
(let ((resize-mini-windows t))
(or noninteractive ;(input-pending-p) init-file-had-error
;; t if the init file says to inhibit the echo area startup message.
- (and inhibit-startup-echo-area-message
- user-init-file
- (or (and (get 'inhibit-startup-echo-area-message 'saved-value)
- (equal inhibit-startup-echo-area-message
- (if (equal init-file-user "")
- (user-login-name)
- init-file-user)))
- ;; Wasn't set with custom; see if .emacs has a setq.
- (condition-case nil
- (with-temp-buffer
- (insert-file-contents user-init-file)
- (re-search-forward
- (concat
- "([ \t\n]*setq[ \t\n]+"
- "inhibit-startup-echo-area-message[ \t\n]+"
- (regexp-quote
- (prin1-to-string
- (if (equal init-file-user "")
- (user-login-name)
- init-file-user)))
- "[ \t\n]*)")
- nil t))
- (error nil))))
+ inhibit-startup-echo-area-message
(message "%s" (startup-echo-area-message)))))
(defun display-startup-screen (&optional concise)
--
2.6.4
next reply other threads:[~2015-12-19 22:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 22:51 Mark Oteiza [this message]
2015-12-20 5:13 ` [PATCH] Remove special requirement to disable startup message Richard Stallman
2015-12-22 18:41 ` Mark Oteiza
2015-12-22 19:39 ` John Wiegley
2015-12-24 1:41 ` Mark Oteiza
2015-12-25 5:48 ` Richard Stallman
2015-12-25 16:24 ` Mark Oteiza
2015-12-23 5:10 ` Richard Stallman
2015-12-24 1:41 ` Mark Oteiza
2015-12-24 3:44 ` Eli Zaretskii
2015-12-25 5:48 ` Richard Stallman
2015-12-24 5:07 ` Random832
2015-12-20 15:46 ` Eli Zaretskii
2015-12-22 19:09 ` Mark Oteiza
2015-12-22 19:27 ` Eli Zaretskii
2015-12-24 1:49 ` Mark Oteiza
2015-12-24 3:45 ` Eli Zaretskii
2016-01-07 0:08 ` Phillip Lord
2016-01-07 0:38 ` John Wiegley
2016-01-07 3:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u4qdpd4.fsf@udel.edu \
--to=mvoteiza@udel.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).