From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ricardo Wurmus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 00/15] xwidget webkit improvements Date: Wed, 26 Oct 2016 07:12:54 +0200 Message-ID: <878ttbhew9.fsf@elephly.net> References: <20161024164101.26043-1-rekado@elephly.net> <2a39f450-c1ae-3fce-8aa4-d12d2e7506ec@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1477458815 30506 195.159.176.226 (26 Oct 2016 05:13:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Oct 2016 05:13:35 +0000 (UTC) User-Agent: mu4e 0.9.16; emacs 25.1.1 Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 26 07:13:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzGWX-00052M-Pv for ged-emacs-devel@m.gmane.org; Wed, 26 Oct 2016 07:13:13 +0200 Original-Received: from localhost ([::1]:59717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzGWZ-00069L-TG for ged-emacs-devel@m.gmane.org; Wed, 26 Oct 2016 01:13:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzGWT-00069D-Hs for emacs-devel@gnu.org; Wed, 26 Oct 2016 01:13:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzGWO-0002y7-Ix for emacs-devel@gnu.org; Wed, 26 Oct 2016 01:13:09 -0400 Original-Received: from sender163-mail.zoho.com ([74.201.84.163]:21397) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzGWO-0002xl-Af for emacs-devel@gnu.org; Wed, 26 Oct 2016 01:13:04 -0400 Original-Received: from localhost (xd933f373.dyn.telefonica.de [217.51.243.115]) by mx.zohomail.com with SMTPS id 1477458779568252.31831932230125; Tue, 25 Oct 2016 22:12:59 -0700 (PDT) In-reply-to: <2a39f450-c1ae-3fce-8aa4-d12d2e7506ec@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 74.201.84.163 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208823 Archived-At: Paul Eggert writes: > Thanks. I tried that on Fedora 24 x86-64, and got the following > diagnostic when using M-x xwidget-webkit-browse-url to visit > http://cs.ucla.edu. > > (emacs:22840): Gtk-WARNING **: Allocating size to GtkOffscreenWindow > 0xd5b6d0 without calling gtk_widget_get_preferred_width/height(). How > does the code know the size to allocate? > > Is this something I should worry about? This warning is also produced by the existing xwidget code in Emacs 25.1. It is harmless, but I did try to remove it and haven’t been successful yet, as I’m not very familiar with GTK. > A couple of minor things. First, in patch "Dynamically resize WebKit > widget", this commit-message line exceeds 78 chars: > > (xwidget-webkit-adjust-size-to-window): Make non-interactive, add widget and window as arguments. > > so "git am" rejected it here. To help prevent this sort of problem in > the future, run "./autogen.sh git". (72 chars or less is nice, so that > ChangeLog lines fit in 80 columns.) > > Second, in the patch "xwidget: Pass JavaScript return value to optional > callback procedure" the new function webkit_js_to_lisp should be static. > To catch this sort of thing in the future, use the --enable-gcc-warnings > option to 'configure'. Thanks for the hints! I’ll wait for additional feedback before sending updated patches. ~~ Ricardo