From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Mon, 05 Dec 2016 21:03:04 -0500 Message-ID: <878trtoluv.fsf@udel.edu> References: <874m2q1oca.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480989838 22634 195.159.176.226 (6 Dec 2016 02:03:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Dec 2016 02:03:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Dima Kogan To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 06 03:03:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cE56m-0004ii-1J for ged-emacs-devel@m.gmane.org; Tue, 06 Dec 2016 03:03:52 +0100 Original-Received: from localhost ([::1]:45588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cE56o-000682-1i for ged-emacs-devel@m.gmane.org; Mon, 05 Dec 2016 21:03:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cE566-00067v-7F for emacs-devel@gnu.org; Mon, 05 Dec 2016 21:03:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cE563-0004iU-4I for emacs-devel@gnu.org; Mon, 05 Dec 2016 21:03:10 -0500 Original-Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:34717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cE562-0004iE-VQ for emacs-devel@gnu.org; Mon, 05 Dec 2016 21:03:07 -0500 Original-Received: by mail-qt0-x241.google.com with SMTP id l20so38398689qta.1 for ; Mon, 05 Dec 2016 18:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rsZtHCVshKR1D0RNnQjQy1niUmmq4JDIt/4r5kaixJM=; b=KbgEVGu/ENCaIWTutcoUMjw/wgB0XyqgSZFBCYJ5ZZkvPwVU6wRNYLMEBAk7p0NmLE mxixw/73jvvFYoQCYfksu/OHhGaPLzv5bvZSiGBtUgzRpxq972jUm/mP2l9rZ6ccGvg/ G3kDj2y6bseIXeODIRGRcLTc2doprmWsQEWzdrYPS3jpodLB1tboZkX1eYun3/MgfTb7 ZwTXMu+hReJ/jm/pIgiEXpa6Do+XYLUb7m49kHjjhR1RO89C48hyCL3TVvnEL9T/4jXC mQjveeXk/3yXepi9cDcK+H35JjImFabtaZDj/jpKcIN0ZnxpH8B5Sla4RzIsvuww1mEu Iocw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rsZtHCVshKR1D0RNnQjQy1niUmmq4JDIt/4r5kaixJM=; b=Fwe27LxxoFJivlKFu2NXrkVJKi+y/DDJ2ZbTA4zsGfrW1wmk4YtBfPKmSOZJsn+ebW VtVU9VEOoc8uOhWOn3Qvg6G5MrO0DVkPqSXsoLVEjHhpgF7iW7U7cmJQyeFafcXrF4oA 35cLwcl0SW9Tne8dt0/dN6YxOBtFcieAgc/d8XaOpbd/R6dxwQIPBxYrZPT0W7haMfIz 7BAyd/SVyei+vlHOTr+VGTDk/SreBE2AxqfgVNqsIy5jRnfKMsUypj1pCUv3Hk+UU/nu OU3MhASac8U9PcIMDDl7UY4yVlPxbZpg0iu+qjBWzc6Z/i0lDux1E4l8ZdIAycUnIXo5 4GfQ== X-Gm-Message-State: AKaTC01Wc4k/4PZtMFAGGIDA7FSFTO5EQR8pQR38B7meb1ueEA8HZ5hvCr+sf493C09Uxkao X-Received: by 10.200.57.54 with SMTP id s51mr51642171qtb.68.1480989785902; Mon, 05 Dec 2016 18:03:05 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id m30sm10923925qta.7.2016.12.05.18.03.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2016 18:03:04 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 5614560D63; Mon, 5 Dec 2016 21:03:04 -0500 (EST) In-Reply-To: <874m2q1oca.fsf@gmail.com> (Tino Calancha's message of "Tue, 29 Nov 2016 21:07:33 +0900") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210085 Archived-At: Fixing C-c C-a to DTRT is great, thanks, but I don't think the off-by-one navigation changes to "n" and "p" (diff-hunk-next, diff-hunk-prev) make sense. While it may have made fixing the issues mentioned in the commit message easier, the changes to what "n" and "p" do at the beginning and end of a diff are not documented, and I didn't see any discussion of it in the associated bug. I contend that the new behavior is inconsistent with the behavior of other outline/thing-with-headers type things in Emacs. outline-mode, org-mode, and rst-mode are the first ones that come to mind. It's also not clear how the introduced oddity with auto-refine is going to be resolved, unless a way is found to autorefine the first hunk without there being any user interaction. Then opening a diff has inconsistent auto-refining from the start.