From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.devel Subject: Re: Issues with quail.el Date: Tue, 08 May 2018 23:19:03 -0400 Message-ID: <878t8tcy8o.fsf@md5i.com> References: <20180505115357.daekqzkpg3565ztj@isis.luna> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1525835870 19237 195.159.176.226 (9 May 2018 03:17:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 May 2018 03:17:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 09 05:17:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGFbu-0004s6-DJ for ged-emacs-devel@m.gmane.org; Wed, 09 May 2018 05:17:46 +0200 Original-Received: from localhost ([::1]:54197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGFdz-0005Dv-PP for ged-emacs-devel@m.gmane.org; Tue, 08 May 2018 23:19:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGFdE-0005Df-8b for emacs-devel@gnu.org; Tue, 08 May 2018 23:19:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGFdB-0007Ml-3V for emacs-devel@gnu.org; Tue, 08 May 2018 23:19:08 -0400 Original-Received: from md5i.com ([75.151.244.229]:52010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGFdA-0007L9-TZ for emacs-devel@gnu.org; Tue, 08 May 2018 23:19:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kPnOpuWG+6AgTOAANIBzA16FXXD460qaqwzWccV08QM=; b=MAn2AVZWv7osN53ANTfi6XjPqh psJoM8qfhnlqg9y/dLdgL3DtEAuiqFPxRdN+6eIKaD8hS5SoB3tr0XbiXQ6FIHJjt4Kc7ghf1o+Qc GWfatq8JudyBGR4DcnqE48Z4L; Original-Received: from md5i by md5i.com with local (Exim 4.91) (envelope-from ) id 1fGFd9-0002io-T5 for emacs-devel@gnu.org; Tue, 08 May 2018 23:19:03 -0400 In-Reply-To: <20180505115357.daekqzkpg3565ztj@isis.luna> (Amit Ramon's message of "Sat, 5 May 2018 14:53:57 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 75.151.244.229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225161 Archived-At: Amit Ramon writes: > I believe I found some bugs in quail.el that occurs when the keyboard > layout is set to a layout that is different from the standard > "quail-keyboard-layout-standard". I'd like to try and fix them myself, > and I have some questions. I'm not a quail expert, but I looked through a lot of the code recently to try to figure out how to do something else, so maybe I can figure out how to help here. > First issue > > Assume that the keyboard layout is set to "atari-german" and that the > input method is "Hebrew". When I type C-h I (thus invoking > "describe-input-method"), the drawing of the keyboard layout is > incorrect. The keys that appear in the shifted level, which should be, > in this input method, similar to those in the standard layout, are > actually taken from the current keyboard layout. Okay, let's verify some things. When I type=20 `M-x quail-show-keyboard-layout RET atari-german RET', I get the following: Keyboard layout (keyboard type: atari-german) +----------------------------------------------------------------+ | 1! | 2" | 3=C2=A7 | 4$ | 5% | 6& | 7/ | 8( | 9) | 0=3D | =C3=9F? | '= ` | #^ | +----------------------------------------------------------------+ | qQ | wW | eE | rR | tT | zZ | uU | iI | oO | pP | =C3=BC=C3=9C | += * | +------------------------------------------------------------+ | aA | sS | dD | fF | gG | hH | jJ | kK | lL | =C3=B6=C3=96 | =C3= =A4=C3=84 | ~| | +--------------------------------------------------------------+ | <> | yY | xX | cC | vV | bB | nN | mM | ,; | .: | -_ | +------------------------------------------------------+ +-----------------------------+ | space bar | +-----------------------------+ Is this what you get as well? Does this match your actual keyboard? > For example, the Hebrew letter TET is on the (standard) y key, and > pressing this key together with shift when Hebrew input method is > active should produce Y. This works fine when typing, but in the map > drawn by "describe-input-method" the letter that appears on this key > in the shifted state is Z, which is what this key does in > "atari-german" layout. There are some other keys not in the right > place - all those that in "atari-german" have a meaning that is > different than the one in the standard layout. Also to verify, the 'y' key is the one to diagonally down and to the right of the 'a' key? Like in the layout above? When I try to recreate what you are showing, I get the following. Does this match? +----------------------------------------------------------------+ | 1! | 2" | 3=C2=A7 | 4$ | 5% | 6& | 7/ | 8( | 9) | 0( | =C3=9F? | '` = | ;^ | +----------------------------------------------------------------+ | qQ | 'W | =D7=A7=E2=80=8EE | =D7=A8=E2=80=8ER | =D7=90=E2=80=8ET |= =D7=98=E2=80=8EZ | =D7=95=E2=80=8EU | =D7=9F=E2=80=8EI | =D7=9D=E2=80=8EO = | =D7=A4=E2=80=8EP | ]} | [{ | +------------------------------------------------------------+ | =D7=A9=E2=80=8EA | =D7=93=E2=80=8ES | =D7=92=E2=80=8ED | =D7=9B= =E2=80=8EF | =D7=A2=E2=80=8EG | =D7=99=E2=80=8EH | =D7=97=E2=80=8EJ | =D7= =9C=E2=80=8EK | =D7=9A=E2=80=8EL | =D7=A3=E2=80=8E=C3=96 | ,=C3=84 | ~| | +--------------------------------------------------------------+ | >< | =D7=96=E2=80=8EY | =D7=A1=E2=80=8EX | =D7=91=E2=80=8EC | =D7=94= =E2=80=8EV | =D7=A0=E2=80=8EB | =D7=9E=E2=80=8EN | =D7=A6=E2=80=8EM | =D7= =AA=E2=80=8E> | =D7=A5=E2=80=8E< | ._ | +------------------------------------------------------+ +-----------------------------+ | space bar | +-----------------------------+ Finally, if it does match, what should it look like instead? > Second issue [...] Snipped until I have a clearer idea what the problem is. --=20 Michael Welsh Duggan (md5i@md5i.com)