org-macs ignoring stock functionality

org-macs ignoring stock functionality

[Sam Steingold]

Hi
I do not use org, but it
accidentally(https://emacs.stackexchange.com/a/46083/795) came to my
attention that org-macs.el duplicates some emacs stock functionality:

1. org-split-string - ignores split-string-default-separators; can
probably be simplified to (split-string string separators nil t)
2. org-current-line - can be replaced with line-number-at-pos
3. org-goto-line - can be replaced with goto-line

Shouldn't these functions be obsoleted? (cf org-compat)

Thanks.

-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

Re: org-macs ignoring stock functionality

[Nicolas Goaziou]

Hello,

Sam Steingold <sds@gnu.org> writes:

> I do not use org, but it
> accidentally(https://emacs.stackexchange.com/a/46083/795) came to my
> attention that org-macs.el duplicates some emacs stock functionality:
>
> 1. org-split-string - ignores split-string-default-separators; can
> probably be simplified to (split-string string separators nil t)

`org-split-string' and `split-string' are slightly different. The former
ignores separators at the beginning and at the end of the string, not
the latter. At some point, it used `split-string', but it happened to be
too slow for a core Org function.

> 2. org-current-line - can be replaced with line-number-at-pos

Indeed, it could be replaced by (line-number-at-pos nil t). I will
obsolete it in Org 9.2.

> 3. org-goto-line - can be replaced with goto-line

Function `goto-line' messes with the mark. From its docstring,

  This function is for interactive use only;
  in Lisp code use ‘forward-line’ instead.

and

  This function is usually the wrong thing to use in a Lisp program.

So, no, `goto-line' cannot replace `org-goto-line'.

Regards,

-- 
Nicolas Goaziou

Re: org-macs ignoring stock functionality

[Sam Steingold]

On Mon, Nov 19, 2018 at 1:30 PM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Sam Steingold <sds@gnu.org> writes:
>
> > I do not use org, but it
> > accidentally(https://emacs.stackexchange.com/a/46083/795) came to my
> > attention that org-macs.el duplicates some emacs stock functionality:
> >
> > 1. org-split-string - ignores split-string-default-separators; can
> > probably be simplified to (split-string string separators nil t)
>
> `org-split-string' and `split-string' are slightly different. The former
> ignores separators at the beginning and at the end of the string, not
> the latter.

Indeed, and the last argument `t` takes care of this difference.

> At some point, it used `split-string', but it happened to be
> too slow for a core Org function.

The org-split-string I see in git master calls split-string.

Thanks.

-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

Re: org-macs ignoring stock functionality

[Nicolas Goaziou]

Sam Steingold <sds@gnu.org> writes:

> On Mon, Nov 19, 2018 at 1:30 PM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> Sam Steingold <sds@gnu.org> writes:
>>
>> > I do not use org, but it
>> > accidentally(https://emacs.stackexchange.com/a/46083/795) came to my
>> > attention that org-macs.el duplicates some emacs stock functionality:
>> >
>> > 1. org-split-string - ignores split-string-default-separators; can
>> > probably be simplified to (split-string string separators nil t)
>>
>> `org-split-string' and `split-string' are slightly different. The former
>> ignores separators at the beginning and at the end of the string, not
>> the latter.
>
> Indeed, and the last argument `t` takes care of this difference.

No, it doesn't. 

Notwithstanding the fact that t is not a valid TRIM argument,
`org-split-string' doesn't trim at all:

(org-split-string "|a| b ||c|" "|") => ("a" " b " "" "c")

> The org-split-string I see in git master calls split-string.

It is no longer the case in Org's HEAD. For the record:

(benchmark-run 1000 (org-split-string "|a|b||c|" "|")) => (0.00832757 0 0.0)
(benchmark-run 1000 (split-string "|a|b||c|" "|" nil " ")) => (0.026091297 0 0.0)


Regards,