From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Gergely Risko <gergely@risko.hu>, emacs-devel@gnu.org
Subject: Re: find-file-hook, recenter, scroll-conservatively and save-place
Date: Thu, 31 Jan 2019 22:57:18 +0200 [thread overview]
Message-ID: <878sz0o9nd.fsf@mail.linkov.net> (raw)
In-Reply-To: <5C52FCDD.7010803@gmx.at> (martin rudalics's message of "Thu, 31 Jan 2019 14:49:17 +0100")
>> My question: is there a better hook that we could use for save-place
>> restoration purposes?
>>
>> I also looked into xref, and there the behavior is much better: the
>> (recenter) is included in the default configuration of
>> xref-after-jump-hook and it works in all the scenarios that I have
>> tried.
>
> Juri, should we handle this somehow?
I don't like the default recentering too. I had to fix it with
a lot of customization, e.g.
(add-hook 'xref-after-jump-hook 'reposition-window)
(add-hook 'xref-after-return-hook 'reposition-window)
(add-hook 'find-function-after-hook 'reposition-window)
;; Let `C-M-a' (beginning-of-defun) not scroll the window
;; when after jumping point stays within current window bounds
(advice-add 'beginning-of-defun :around
(lambda (orig-fun &rest args)
(let ((w-s (window-start))
(w-e (window-end)))
(apply orig-fun args)
(when (and
;; Only when used interactively
(eq this-command 'beginning-of-defun)
;; And only when jumping outside of window
;; to the center of the window
(or (< (point) w-s) (> (point) w-e)))
(recenter 11))))
'((name . recenter)))
;; Save and restore window start positions on returning to previous search
(setq isearch-push-state-function
(lambda ()
;; Recenter new search hits outside of window boundaries
(when (and isearch-success (not (pos-visible-in-window-p)))
;; reposition-window takes too much time in large buffers
(if (or (eq major-mode 'fundamental-mode)
(> (buffer-size) 1000000))
(recenter 11)
(condition-case nil
;; Prevent errors from reposition-window
(reposition-window)
(error nil))))
`(lambda (cmd)
(when isearch-success
(set-window-start nil ,(window-start))))))
> That is, provide 'window-point' and 'window-start' action alist entries
> with the former allowing the 'switch-to-buffer-preserve-window-point'
> logic (among others) and the latter optionally allowing to recenter.
Like switch-to-buffer-preserve-window-point used in dired-find-file?
> I don't know how 'save-place' could pass these on to the
> 'pop-to-buffer' call in 'find-file' though. Can you think
> of any other use cases where these would be helpful?
Interesting question. Maybe introduce two new buffer-local variables
'window-point' and 'window-start' that a hook could set and then
display-buffer could read and call functions window-point and window-start?
These buffer-local values should be used only once and should be reverted
to nil after the first use.
BTW, a related question: should save-place save window-start as well?
It should be easy to implement after this problem is solved.
next prev parent reply other threads:[~2019-01-31 20:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 9:46 find-file-hook, recenter, scroll-conservatively and save-place Gergely Risko
2019-01-31 13:46 ` Gergely Risko
2019-01-31 14:43 ` Eli Zaretskii
2019-01-31 15:31 ` Gergely Risko
2019-01-31 13:49 ` martin rudalics
2019-01-31 14:32 ` Eli Zaretskii
2019-01-31 18:44 ` martin rudalics
2019-01-31 23:47 ` Gergely Risko
2019-02-01 9:05 ` martin rudalics
2019-01-31 20:57 ` Juri Linkov [this message]
2019-01-31 22:45 ` Gergely Risko
2019-02-01 9:05 ` martin rudalics
2019-02-02 21:03 ` Juri Linkov
2019-02-03 20:18 ` Juri Linkov
2019-02-01 9:04 ` martin rudalics
2019-02-01 11:18 ` Gergely Risko
2019-02-02 9:30 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sz0o9nd.fsf@mail.linkov.net \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
--cc=gergely@risko.hu \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).