From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: Issue with ns_color_defined makeIndex argument Date: Sat, 13 Apr 2019 10:16:59 -0600 Message-ID: <878swdvq10.fsf@gmail.com> References: <87lg0gttmf.fsf@gmail.com> <20190413100933.GA20582@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="249624"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 13 18:17:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFLL5-0012qq-61 for ged-emacs-devel@m.gmane.org; Sat, 13 Apr 2019 18:17:11 +0200 Original-Received: from localhost ([127.0.0.1]:53476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFLL3-0004eW-Ut for ged-emacs-devel@m.gmane.org; Sat, 13 Apr 2019 12:17:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFLKy-0004eO-0J for emacs-devel@gnu.org; Sat, 13 Apr 2019 12:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFLKw-0003jN-B3 for emacs-devel@gnu.org; Sat, 13 Apr 2019 12:17:03 -0400 Original-Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:46708) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFLKw-0003ee-2K for emacs-devel@gnu.org; Sat, 13 Apr 2019 12:17:02 -0400 Original-Received: by mail-pf1-x430.google.com with SMTP id 9so6542567pfj.13 for ; Sat, 13 Apr 2019 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Wwavcjs5zPgQ+RiTAYXERKYMASp02EKErpJclfSjLm8=; b=bvl5o/xbjdHt/i7w5B6WCcHFY42aL3XMm4sQjrohQQLkvWgjUk52fL4s4tyzzfRYWf n9tM0wOPO4OWkxOzklRTZoqi9UKJf6hqwsOXMMt2em8Zjz1/RzZM+XCmuSzzn3wtyJr0 ROY/Z3X6wPGAIaWL1CjBU7IrOx7GGKFfAoSmtPOpXai/2PsqmU9xiZuMusJ4LMU+DKDl 5EK1WZF4UvqED0KxbEX7Vm+uklz3c3oGDANn63t/lAu3NpCmi4eyUQf1FlUo+gPComeR Qay3/pu2mDIHultIfDONMFxE/54moOvMKuG5apfTmeENVkWCvKcSDJxVmG98koRkl67b yizw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Wwavcjs5zPgQ+RiTAYXERKYMASp02EKErpJclfSjLm8=; b=Xjh3pT2cP6o0+GIyU6pdPD+73ug8rRG3Gm/WXQmahy02/OoVIi/Vs7H124VNBecDX+ UITYUYjGtVy82cRQPHe01C/PRuG2yMSYmk440eo8WULBdQ359gIPRk4YZyXbroRLyGYG NgyirejRaYHYbahBZckr/Ym+eehB1YOVu/Hxzbjf4/WPMQQJSm+8jDFVL0jKkJ/gahJ6 vEpGglCLhxQC+dUMXohLDnBqV2DYpZRGRWZWkFpZpE1xIBnt7bP3QFvRlyNc0p0j9FRQ noz/vN73f+uCAY23l2LX+iea6YIWKmPUBFKfqrlwsI5ox8JQcpovNvBU5FB5HufAaiWx ymxA== X-Gm-Message-State: APjAAAXanPsXieqNvSunhLd4UNV5G8Q0mw4IcsfM5iETAB+0Jrwdcx/I X/SMkZjtR/2KlD4wDlKmqc74RbIv X-Google-Smtp-Source: APXvYqyHmOJGq0m8TubbJJTcDMpJnxNaoJXu3OMw1FIhKqykWxWPzz80VOM+TiR3mnAuRxP3BkgjYQ== X-Received: by 2002:a63:2c3:: with SMTP id 186mr58668863pgc.161.1555172219961; Sat, 13 Apr 2019 09:16:59 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id h4sm57592274pgn.20.2019.04.13.09.16.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Apr 2019 09:16:59 -0700 (PDT) In-Reply-To: <20190413100933.GA20582@breton.holly.idiocy.org> (Alan Third's message of "Sat, 13 Apr 2019 11:09:33 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::430 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235399 Archived-At: Alan Third writes: > I=E2=80=99m not familiar with this area of the code, and a review hasn=E2= =80=99t done > anything to enlighten me. This code has been in since the NS port was > merged, so there=E2=80=99s no explanatory reasoning in commit messages. > > If I=E2=80=99m reading the code right, when we lookup a colour in image.c= , we > store a 32bit integer representation of the colour in color_def.pixel, > but when doing a lookup from xfaces.c, we store an index into a lookup > table in color_def.pixel. > >> If so, does anyone have any ideas to rectify this besides adding an >> extra argument that non-NS window systems just ignore? I'd rather avoid >> doing that. > > I have no ideas, I=E2=80=99m afraid. Alright, I just made a wrapper procedure to accommodate NS instead. Thanks for looking at this.