From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Solving bug#35564 (was: Use of minibuffer-prompt face when minibuffer is not involved) Date: Sat, 11 May 2019 15:50:33 +0200 Message-ID: <878svdyuae.fsf_-_@gmail.com> References: <8736lmi2dg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="192637"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 11 16:00:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPSXh-000nzM-U5 for ged-emacs-devel@m.gmane.org; Sat, 11 May 2019 16:00:02 +0200 Original-Received: from localhost ([127.0.0.1]:59148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPSXg-00080E-RA for ged-emacs-devel@m.gmane.org; Sat, 11 May 2019 10:00:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPSOc-0004eC-NJ for emacs-devel@gnu.org; Sat, 11 May 2019 09:50:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPSOb-000434-QE for emacs-devel@gnu.org; Sat, 11 May 2019 09:50:38 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:38540) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPSOb-00042S-I4 for emacs-devel@gnu.org; Sat, 11 May 2019 09:50:37 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id v11so10624421wru.5 for ; Sat, 11 May 2019 06:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lsP6DiaAv2WjtV7ZmNmwsu9DUp2kAYl10mYENeQMiR4=; b=WSZAAxM8i3O568hfwSGHjCq/77g8pkbyFbyfuxZpyM3srNqPDPDgxZ8gn4lsNsdYSn Bm/LZaD32pZaCpjkQkauACb9Lk9849Ovp4iutbjWyF4UXLzihv9P6Y2kgij6taPVMUrN 4BjZ1EPNuhiYrzRd5QbnunXmfzlSDGAB2ndnGpvfdXQGNGLCtZv3Do2KTI6j1OAqMIkj TIhEWmf16xtVsDZr7OL35YOLSYBqTzdo55uvYb4UjiIepus+tXytdJBOb3mis+gqNf2P dIgMcxzEU0rkxs5nzm1++yjgLfWCnPHORQNpV/AKZVRnhEtEXonFs5bZPgBfAgKkibRr fOUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lsP6DiaAv2WjtV7ZmNmwsu9DUp2kAYl10mYENeQMiR4=; b=K+i1A8w4qD056qbXgNV1bck5J/C8oM+QiKPkdFmXDx5pkPsbjiAO/jxW5dWTMIZpy+ IZb5tJ5r0zEYeuGOisJK04yq8hQrK//Fygo2guCiU/lfMZ5v8Ax3dbdtmqLBAqNo001D wycvD9/YuVMJjUUH83q/cbBkpn/ypdeMzhiJ9UzGQYXZ9DaWermfHuivSiAtVaL2Kk4/ RbDuhH1HVo5JDApeeR9nBPjRTRyEQu38+ee3PjlQ0jEVdkTaBiGl6EAkYQqw+kf6xsoL BiMYV5khxVMyZLe292AHQNNPsuhOO2TP3/7LE8o7sJj5lDzy7u+tdpYTH4p9Xzb6Ow5m A9rg== X-Gm-Message-State: APjAAAXeKjMdQdwvL3H/kUhKt4CO8HmawC6cu/AAhovu+Saig72X2gcg 9+2nKVy8+Odf7/EJ5cIrx/ZOq2MG X-Google-Smtp-Source: APXvYqxIJQKTPboCA+iIOvBnrC0YB09dyopp4QLPXSKI7Xj7yx82jWQesb4NR/uGkA4+7kRvgOCoEw== X-Received: by 2002:a5d:4712:: with SMTP id y18mr10922985wrq.23.1557582635713; Sat, 11 May 2019 06:50:35 -0700 (PDT) Original-Received: from nc10-laptop ([92.184.112.94]) by smtp.gmail.com with ESMTPSA id x18sm7915200wrw.14.2019.05.11.06.50.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 May 2019 06:50:35 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 10 May 2019 16:52:46 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 X-Mailman-Approved-At: Sat, 11 May 2019 09:58:27 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236424 Archived-At: Stefan Monnier writes: > So the problem is not the use of minibuffer-prompt but the fact that it > overrides other faces while applying it. That should be easy to fix by > using `add-face-text-property` instead of `propertize`. Yep, which is what the patch over at bug#35564#11 does. Now it's mostly a matter of deciding whether we want to solve this bug this way (IMO: not if someone can simply come up with a better warning and do away with my highlighted-prompt shenanigans). If we do, I'll add a proper patch series to this report, to 1. fix y-or-n-p with add-face-text-property, 2. tweak dired's warning using text properties.