From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Fri, 07 Jun 2019 23:04:44 +0200 Message-ID: <878sudgl8z.fsf@killashandra.ballybran.fr> References: <87pnobiglo.fsf@killashandra.ballybran.fr> <83r28p57jp.fsf@gnu.org> <87zhnd55eq.fsf@killashandra.ballybran.fr> <83mujd54qv.fsf@gnu.org> <87lfyr4p49.fsf@killashandra.ballybran.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161702"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 07 23:05:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZM2q-000fvY-TC for ged-emacs-devel@m.gmane.org; Fri, 07 Jun 2019 23:05:05 +0200 Original-Received: from localhost ([::1]:53210 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZM2p-0002Ah-7C for ged-emacs-devel@m.gmane.org; Fri, 07 Jun 2019 17:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34793) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZM2j-0002AO-Ee for emacs-devel@gnu.org; Fri, 07 Jun 2019 17:04:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZM2i-0002Da-F8 for emacs-devel@gnu.org; Fri, 07 Jun 2019 17:04:57 -0400 Original-Received: from smtp4-g21.free.fr ([212.27.42.4]:44446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZM2e-0001zU-3U; Fri, 07 Jun 2019 17:04:52 -0400 Original-Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e0a:1e2:f8b0:9cc3:35bf:aa81:ccf7]) by smtp4-g21.free.fr (Postfix) with ESMTPS id 18BC719F5AB; Fri, 7 Jun 2019 23:04:44 +0200 (CEST) In-Reply-To: <87lfyr4p49.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Mon, 27 May 2019 22:30:14 +0200") X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 212.27.42.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237315 Archived-At: Had you have a chance to look at my patches ? Should/Could I do something ? pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > Eli Zaretskii writes: > >>> From: pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) >>> Cc: emacs-devel@gnu.org >>> Date: Thu, 23 May 2019 21:37:01 +0200 >>>=20 >>> > I'd suggest to call the new argument base64url or somesuch, since >>> > this is trhe official name. >>> > >>> You mean in replacement of url_variant or b64_value_to_char ? >> >> The former. >> >>> How should I send new versions of the patch ? As a full patch in >>> attachment like previously ? >> >> Yes. And please include the log messages (in the ChangeLog style). >> >> > You'll find two patches attached. > First one contains requested changes and, hoppefully, a valid Changelog > > > > The second patch contains an reworked version wich instead of adding > many parameters to base64-encode-region (resp. base64-encode-string) > function create the base64url-encode-region > (resp. base64url-encode-string) function. Documentation and tests are > also updated consequently. > > > > Tell me what you thing is the way to go.