From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use lexical-binding in button.el Date: Fri, 04 Oct 2019 00:00:37 +0100 Message-ID: <878sq1sacq.fsf@tcd.ie> References: <87a7akzkl3.fsf@tcd.ie> <87wodnv2vz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="228707"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 04 01:29:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGAX9-000xPO-SA for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2019 01:29:19 +0200 Original-Received: from localhost ([::1]:41050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGAX8-0007g6-3C for ged-emacs-devel@m.gmane.org; Thu, 03 Oct 2019 19:29:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGA5Z-0006vZ-7Y for emacs-devel@gnu.org; Thu, 03 Oct 2019 19:00:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGA5U-0003l7-Qr for emacs-devel@gnu.org; Thu, 03 Oct 2019 19:00:48 -0400 Original-Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:37034) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGA5R-0003iG-3I for emacs-devel@gnu.org; Thu, 03 Oct 2019 19:00:42 -0400 Original-Received: by mail-wm1-x342.google.com with SMTP id f22so3798272wmc.2 for ; Thu, 03 Oct 2019 16:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=+ot6+jjxP/vua9N+y26OgBGnIYgtebBWkOi7GWDEZcU=; b=pzO6MEPvH9j4ip4OUHB9wPReZbRG6NQGuF/Fj3TL4fphNvmno6lZFNqd/iF0K5McVJ nEztG19Ea4worG3FVCC7jmFHAvspiCQtz3HY+G9raAf4Ts8oOng7mgfKm/5SL/4uma9a w1fnPuT1ICbQtdZWM73gbRH0ZFkx852kW1pDsIxDuk57kWaZxZix2RCP/ptwU6DNLZo0 J1VyH93FszjBAiQ41X1+RHDG/u/1m+z2Ky5z9+BxGqat+uZk3c7y5WbI3IMzbqA/0eXq rsyhbo4yiD/A/aXz7R8Ppz4sxiqwmvqeilHzIi0U30JmTqK8RRNIOFClBNZlShdlGyGv bhQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=+ot6+jjxP/vua9N+y26OgBGnIYgtebBWkOi7GWDEZcU=; b=U4LFRbMXFuiy5DXh0P63xqcyDwsdTwHPKs4QjkAyX53myqJODoIiFKGp391iNuxh7O 2fN5OkRTuIPDRDekor74FxwhFElQOWJmN5TcD/jKg5OXQQ/pRyPKGbhDenHSpr2TcNw/ PqZ9g8pb4joAWQ2OYpipthl9ERe6zyJOCLuRok0KFW8CKWipkHCCdeCoai1GPq49v029 t+L9E8yEc8OgAUt9kwxxrVe6FtfPSucq/Z2L2d/j381fw2WvOtMsB/O8Avpz0BdZtBwg 2SFmsltU//d6V07DrK5pwkwecg/jC5SgMldouEXBJUC+UIiAKmViZyy6WaUm9vHLpRqP 1ynw== X-Gm-Message-State: APjAAAWViypM5xqo7KJyulNsTpQABmLv3AsKhXO4S9NFzl7+J6l4wZF0 ds4/4eX8yU58nRawO3nLZrP1081MkCFksA== X-Google-Smtp-Source: APXvYqzP8xY7DZjLXTtRVZgAw1opgChRyauI9FeeHrsaI9C1d/1riXHRsnyE+O8O+rYbKwNgECr1Kw== X-Received: by 2002:a1c:4384:: with SMTP id q126mr9209953wma.153.1570143639576; Thu, 03 Oct 2019 16:00:39 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id u83sm12808624wme.0.2019.10.03.16.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 16:00:38 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240540 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> The following patch enables lexical-binding and touches up some >> documentation in button.el, WDYT? (More unit tests for button.el are on >> their way in bug#37515.) > > Looks good to me. Thanks, pushed to master: Use lexical-binding in button.el 660d509acd 2019-10-03 23:04:56 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=660d509acd9da23d9795b5aaa12a5453e6c61bbd -- Basil