unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuri D'Elia <wavexx@thregr.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 5ee43ba0df causing display hangs?
Date: Sun, 08 Dec 2019 00:03:35 +0100	[thread overview]
Message-ID: <878snn3fi0.fsf@wavexx.thregr.org> (raw)
In-Reply-To: <83muc4djwg.fsf@gnu.org>

On Sat, Dec 07 2019, Eli Zaretskii wrote:
> Thanks.  Then I guess I will need that recipe to see where I goofed.

Tried a few times to get a small repro, but this might be easier to be
debugged.

> memcpy (inherited_attrs, attrs, LFACE_VECTOR_SIZE * sizeof (attrs[0]));
> while (UNSPECIFIEDP (attr_val)
>        && !NILP (inherited_attrs[LFACE_INHERIT_INDEX])
>        && !UNSPECIFIEDP (inherited_attrs[LFACE_INHERIT_INDEX]))
>   {
>     Lisp_Object parent_face = inherited_attrs[LFACE_INHERIT_INDEX];
>     bool ok;
>     if (CONSP (parent_face))
>       {
>         Lisp_Object tail;
>         for (tail = parent_face; !NILP (tail); tail = XCDR (tail))
>           {
>             ok = get_lface_attributes (w, f, XCAR (tail), inherited_attrs,
>                                        false, named_merge_points);
>             if (!ok)
>               break;

While attaching with gdb I noticed this is where it gets stuck in a loop.
get_lface_attributes returns !ok, break stops only the for loop, but
since nothing else changed for the upper "while" it goes on forever.

Looking at few lines below, it looks like this needs to break out of the
while() as well?



  reply	other threads:[~2019-12-07 23:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07 13:08 master 5ee43ba0df causing display hangs? Yuri D'Elia
2019-12-07 17:42 ` Eli Zaretskii
2019-12-07 18:14   ` Eli Zaretskii
2019-12-07 18:56     ` Yuri D'Elia
2019-12-07 19:18       ` Eli Zaretskii
2019-12-07 23:03         ` Yuri D'Elia [this message]
2019-12-08 15:55           ` Eli Zaretskii
2019-12-08 16:03             ` Yuri D'Elia
2019-12-08 16:57               ` Eli Zaretskii
2019-12-10 10:57                 ` Yuri D'Elia
2019-12-10 12:01                   ` Eli Zaretskii
2019-12-11 11:36                     ` Yuri D'Elia
2019-12-11 17:14                       ` Eli Zaretskii
2019-12-11 17:29                         ` Yuri D'Elia
2019-12-11 17:47                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878snn3fi0.fsf@wavexx.thregr.org \
    --to=wavexx@thregr.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).