From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Add user customization fido-completion-styles Date: Tue, 02 Jun 2020 21:00:06 +0100 Message-ID: <878sh5w855.fsf@gmail.com> References: <87r1uzn018.fsf@gmail.com> <953E1512-6420-4AE8-AF29-15AB151B6344@schwartzmeyer.com> <877dwpn2id.fsf@gmail.com> <3483a8d9-1474-45cf-afad-8d276b96ef3f@default> <87sgfdl5jw.fsf@gmail.com> <83img9cp7j.fsf@gnu.org> <87o8q1l40i.fsf@gmail.com> <83h7vtco49.fsf@gnu.org> <87h7vtl1u2.fsf@gmail.com> <83eeqxclrx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="117591"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 02 22:01:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgD5s-000UVn-75 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jun 2020 22:01:04 +0200 Original-Received: from localhost ([::1]:51400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgD5r-0005zW-80 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jun 2020 16:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgD52-0005Sp-0A for emacs-devel@gnu.org; Tue, 02 Jun 2020 16:00:12 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:40428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgD50-0003AQ-T9; Tue, 02 Jun 2020 16:00:11 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id r15so4370984wmh.5; Tue, 02 Jun 2020 13:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=GX3a83kD0p8baOheGUDjLryXwCQpAhRaZ+pYIolGDIc=; b=c1gCEnpfd/N62/JaQiHkMN/6DfxLl/2RibpO9bOAEea4lEVfB3yeCrLh3Va7yRZhSs dXL6+Wbhb9dTdw4RWSVhUbTdKMRSPPWMu2pAfTpngDhoScPbbkNqVhCfI/UjHs6+F6k9 5Bh2gt4WVCWZ5KWzM44siVSniBAWLBeMO8d3TyXUfgFRy3rpCSLifpWq3/coCYgU9u24 2GfA0iH8IvSOxCqPZbpPsx3zLr8ogF6cOsD0wewcnqCUrNzlgNhC5+rXfWbGoMBm+yN5 UB8CveCqLZfEGsE3u5OWB4PwU34ScU2Bd1J3LWd/8B2cOJdctO70D7lmA5eKXTpX2cMn blkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=GX3a83kD0p8baOheGUDjLryXwCQpAhRaZ+pYIolGDIc=; b=UNqE996B4x8ppgZvt58ZsaBxA61ve/4Cy7Dcrx0tarns0HojaFpmpGe2OxUTjpZEf6 BerFtUhjLw7zQFbfZQljzcGFpJIiNBZ55HddmKYq9Hw7pZ5Px6bC0QP4J4m7YW1co5kc MbJh5OaMDTwT8NqrvtJ+mlhun9M8P/2g6EUtOjmaZlyEyBSuYmYPIk5K2+g+XGY+KyMu jca46nRu/caD8VHkUKcZNXeHg7bU06scsWaZTOXx1lB61NKJVGX68y6IRj9zhOZaFHEF inWpZwHVxh0VwgvZSZiIkhIcBFJ9KspDpcOOa0W0sd1N4XqcV5gUHu52tT1H3xixDeD3 vFzA== X-Gm-Message-State: AOAM533ttdKzQ0oAlvxjxDbxYAxbFilWx8JpO9FQtHaPjfcyp+COLpOy AV+s+IhjhPLUO7v1K8T65ug= X-Google-Smtp-Source: ABdhPJxFP5rPYf++6a4LrWSVcSgkPg4gSiir/n+SIS1yCCBlLS1MpQisU0CFccEyZKXnIezz+KAgNg== X-Received: by 2002:a1c:5683:: with SMTP id k125mr5834425wmb.55.1591128009293; Tue, 02 Jun 2020 13:00:09 -0700 (PDT) Original-Received: from krug ([89.180.144.241]) by smtp.gmail.com with ESMTPSA id x18sm993739wmi.35.2020.06.02.13.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 13:00:08 -0700 (PDT) In-Reply-To: <83eeqxclrx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Jun 2020 22:25:54 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x334.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251782 Archived-At: Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Cc: drew.adams@oracle.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca >> Date: Tue, 02 Jun 2020 20:11:49 +0100 >>=20 >> - complete-with-action 1125 75% >> - cond 1125 7= 5% >> - funcall 1125 7= 5% >> - all-completions 24 = 1% >> # 15 = 1% > > This looks like funcall takes most of the time, so it's important to > understand which function is being called here. I think it's something in simple.el, given as the profile changes completely once I load that file versus loading simple.elc. >> - completion-pcm--all-completions 12= 09 78% >> - all-completions 1209 7= 8% >> - # 31= 8 20% >> - let 318 2= 0% >> - complete-with-action 318 2= 0% >> - all-completions 10 = 0% >> - # = 5 0% > > Is this real? all-completions calls some lambda which itself calls > all-completions? It might be yes, judging from the docstring, the C implementation of all-completions, and the evidence we're looking at. >> - all-completions 5 = 0% >> - # = 4 0% >> - and 4 = 0% >> funcall 4 = 0% >> + # 177= 11% >> + # 172= 11% >> + # 1= 65 10% >> + completion-pcm--hilit-commonality = 21 1% > > What are all those lambda-functions? No idea. I'd suppose they are the functions who are checking the predicate against the symbols in obarray, since we want only the symbols that verify commandp and aren't marked as obsolete. I've expanded the first two lambdas of the 5 we have in total. I think that's the amount of types I pressed 'M-x C-g' waiting for the completions to show up between the M-x and the C-g. None of this was with an Emacs -Q, though. If I use an Emacs -Q I just have one of those mysterious lambdas, even if I do do the 'M-x C-g' multiple times. - completion--some 111 42% - #