* Re: master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328)
[not found] ` <20200731040357.201EE20CB4@vcs0.savannah.gnu.org>
@ 2020-08-09 11:34 ` Michael Heerdegen
2020-08-09 14:15 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Michael Heerdegen @ 2020-08-09 11:34 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
stefankangas@gmail.com (Stefan Kangas) writes:
> ;; For compatibility with older versions.
> ;;;###autoload
> -(defalias 'manual-entry 'man)
> +(define-obsolete-function-alias 'manual-entry 'man "28.1")
FWIW - but: I lost 30 minutes to find out why completion is broken: M-x
manu TAB doesn't complete any more to manual-entry (you get "no match"),
although manual-entry RET works. If you don't know that the above
change has been made, this behavior is very confusing.
Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328)
2020-08-09 11:34 ` master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328) Michael Heerdegen
@ 2020-08-09 14:15 ` Eli Zaretskii
2020-08-09 15:10 ` Michael Heerdegen
2020-08-09 16:39 ` Stefan Kangas
0 siblings, 2 replies; 5+ messages in thread
From: Eli Zaretskii @ 2020-08-09 14:15 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: stefankangas, emacs-devel
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Date: Sun, 09 Aug 2020 13:34:28 +0200
> Cc: Stefan Kangas <stefankangas@gmail.com>
>
> stefankangas@gmail.com (Stefan Kangas) writes:
>
> > ;; For compatibility with older versions.
> > ;;;###autoload
> > -(defalias 'manual-entry 'man)
> > +(define-obsolete-function-alias 'manual-entry 'man "28.1")
>
> FWIW - but: I lost 30 minutes to find out why completion is broken: M-x
> manu TAB doesn't complete any more to manual-entry (you get "no match"),
> although manual-entry RET works. If you don't know that the above
> change has been made, this behavior is very confusing.
If this change causes inconvenience, we should revert it, IMO.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328)
2020-08-09 14:15 ` Eli Zaretskii
@ 2020-08-09 15:10 ` Michael Heerdegen
2020-08-09 16:39 ` Stefan Kangas
1 sibling, 0 replies; 5+ messages in thread
From: Michael Heerdegen @ 2020-08-09 15:10 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: stefankangas, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> > FWIW - but: I lost 30 minutes to find out why completion is broken: M-x
> > manu TAB doesn't complete any more to manual-entry (you get "no match"),
> > although manual-entry RET works. If you don't know that the above
> > change has been made, this behavior is very confusing.
>
> If this change causes inconvenience, we should revert it, IMO.
I can switch to using M-x man. But I dunno how many people are used to
the other name, and it's not trivial to see what's happening, since
completion just behaves inconsistent. Instead of denying to complete a
name that RET then accepts, it would be better to complete and maybe
omit a warning, or to not accept the obsoleted name at all.
Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328)
2020-08-09 14:15 ` Eli Zaretskii
2020-08-09 15:10 ` Michael Heerdegen
@ 2020-08-09 16:39 ` Stefan Kangas
2020-08-09 17:17 ` Eli Zaretskii
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2020-08-09 16:39 UTC (permalink / raw)
To: Eli Zaretskii, Michael Heerdegen; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> > -(defalias 'manual-entry 'man)
>> > +(define-obsolete-function-alias 'manual-entry 'man "28.1")
>>
>> FWIW - but: I lost 30 minutes to find out why completion is broken: M-x
>> manu TAB doesn't complete any more to manual-entry (you get "no match"),
>> although manual-entry RET works. If you don't know that the above
>> change has been made, this behavior is very confusing.
>
> If this change causes inconvenience, we should revert it, IMO.
I've now reverted this part of the patch on master.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328)
2020-08-09 16:39 ` Stefan Kangas
@ 2020-08-09 17:17 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2020-08-09 17:17 UTC (permalink / raw)
To: Stefan Kangas; +Cc: michael_heerdegen, emacs-devel
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 9 Aug 2020 09:39:19 -0700
> Cc: emacs-devel@gnu.org
>
> > If this change causes inconvenience, we should revert it, IMO.
>
> I've now reverted this part of the patch on master.
Thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-09 17:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200731040355.3076.47146@vcs0.savannah.gnu.org>
[not found] ` <20200731040357.201EE20CB4@vcs0.savannah.gnu.org>
2020-08-09 11:34 ` master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328) Michael Heerdegen
2020-08-09 14:15 ` Eli Zaretskii
2020-08-09 15:10 ` Michael Heerdegen
2020-08-09 16:39 ` Stefan Kangas
2020-08-09 17:17 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).