From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: select yank via completion Date: Wed, 25 Nov 2020 09:36:27 +0200 Organization: LINKOV.NET Message-ID: <878sapnb0k.fsf@mail.linkov.net> References: <87wnymda5g.fsf@mail.linkov.net> <87ima5he8j.fsf@mail.linkov.net> <87mtzfzt9a.fsf@mail.linkov.net> <87k0uifp3w.fsf@mail.linkov.net> <87d009iykt.fsf@mail.linkov.net> <3341c426-3a86-4ef0-a0ca-9102191a925b@default> <87o8jsiems.fsf@mail.linkov.net> <87o8jmbbu9.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: spacibba@aol.com, Jean Louis , andreyk.mad@gmail.com, emacs-devel@gnu.org, rudalics@gmx.at, Stefan Monnier , Gregory Heytings , Eli Zaretskii , Drew Adams To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 25 08:55:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khpeN-0008bg-7U for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 08:55:39 +0100 Original-Received: from localhost ([::1]:53972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khpeM-0003BX-8m for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 02:55:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khpdJ-0002Ir-Cu for emacs-devel@gnu.org; Wed, 25 Nov 2020 02:54:33 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:44959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khpdH-0002qW-8D; Wed, 25 Nov 2020 02:54:32 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5C4181BF20E; Wed, 25 Nov 2020 07:54:24 +0000 (UTC) In-Reply-To: <87o8jmbbu9.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 24 Nov 2020 22:59:26 +0000") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259769 Archived-At: >> + (when (> (length s) (- 40 b)) >> + (add-text-properties >> + (min (+ b 40) (length s)) (length s) >> + `(display ,ellipsis) s)) > > Any chance this threshold can be configurable? I don't mind completions > as wide as or wider than the frame in Ivy's minibuffer. The default value 40 was intended to be able to accommodate two columns of completions in the *Completions* buffer in the default 80-column wide frame, but indeed a hard-coded constant should be avoided. Instead of adding a specific defcustom for kill-ring completions, maybe some more general option is possible in minibuffer.el? Something like how many columns the user expects for completions. If a package like ivy is not column-oriented as the *Completions* buffer, then ivy could set such an option to 1. Then yank-pop could truncate completions to the frame width. Or such truncation should be moved to minibuffer.el and extended with other features from its TODO item: ;; - indicate how to display the completions in *Completions* (turn ;; \n into something else, add special boundaries between ;; completions). E.g. when completing from the kill-ring.