From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 07 Dec 2020 22:47:35 +0100 Message-ID: <878sa970g8.fsf@gnus.org> References: <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> <87czzl716z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29624"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , Eli Zaretskii , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 22:50:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmOOc-0007Yp-L7 for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 22:50:14 +0100 Original-Received: from localhost ([::1]:56624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmOOb-0006ch-NC for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 16:50:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmOMC-0005qf-8E for emacs-devel@gnu.org; Mon, 07 Dec 2020 16:47:44 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmOMA-0002q2-MI; Mon, 07 Dec 2020 16:47:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=h6hXt3et5Sg8X2637arETuzPBmc9YP8xLdTgdyoskOI=; b=NPXgJ0e7UkT8cNA6Wn4rlxIb4M Mle46kRhV26aLT3sRIXLtPypF8LUDTrJoXy73A8jLrJj79yI5DCN2CkGkKWvzs97tSJ4Y8xQ9B02k RapU7GhhRSLM2rUyXA3p22AQzKs7+n2tyH3KC5+ICA+DAtMAsDWw5W+KwYwOn7+UiH58=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmOM4-0002Bf-BI; Mon, 07 Dec 2020 22:47:39 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX68O3TnqSnXHNA Jjz///9E1ZYgAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMBxUcI0fbazgAAAGGSURBVDjLdZTrkYUw CIVBGwjYQCANrKH/3hYSkr3OdZnxh/lyDi9HAAAkOFpX+ArEcmjTAi/BpFRfgbzeBzj+I4iV3gFU eJU0EeSCHUeNhQomOOt9XHpa50rhSquro1i/9LJbBZGE1DaQQ4+zF+EAqm2BKgchCrgTAWtfYLTh WRFjBtzMYKZnf6tnFb+vShqAonx0U3OzAH7Hzz25kDsom4kSMV6qatYdFBbA5pd6p3DqLYjFmrhC iC0KuPwC4RU5WFnLGeBnnEvkbA5c6PIARuEx9sXNC1V7RM1xJ2gbSPYcHWRMw3sDS0W/20MxBd4D 0ZWKmNsDTCsiP97g9iVQZveBlgW69+lPVtFaIYjc3ccXU00zj8JDIZFAd/qYgUS540iHaikkRvIh 2FnYXKEDZCTQAPOcHwrfBz8EPGocO89j/SN9TA98zdtoVjen6mOkR6yKF2BNszZTfCvWNr/A6v0L 6Dv4+2YSRJfyOcXxic7qNdt4AN7gI/kCz/4mSEE87L+hAX4BNbZt41DXAP4AAAAldEVYdGRhdGU6 Y3JlYXRlADIwMjAtMTItMDdUMjE6Mjg6MzUrMDA6MDBLQm9pAAAAJXRFWHRkYXRlOm1vZGlmeQAy MDIwLTEyLTA3VDIxOjI4OjM1KzAwOjAwOh/X1QAAAABJRU5ErkJggg== X-Now-Playing: Throwing Muses's _Sun Racket_: "Frosting" In-Reply-To: <87czzl716z.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 07 Dec 2020 22:31:32 +0100") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260523 Archived-At: Lars Ingebrigtsen writes: > So there's something off about how the image specs are being compared in > the two cases. With the following instrumentation: diff --git a/src/image.c b/src/image.c index 5eb4132295..f89649c61d 100644 --- a/src/image.c +++ b/src/image.c @@ -1597,8 +1597,12 @@ make_image_cache (void) static bool equal_lists (Lisp_Object a, Lisp_Object b) { + CALLN (Fmessage, build_string("%S %S"), + a, b); while (CONSP (a) && CONSP (b) && EQ (XCAR (a), XCAR (b))) a = XCDR (a), b = XCDR (b); + CALLN (Fmessage, build_string("%S %S"), + a, b); return EQ (a, b); } I consistently get this from the toolbar icons: (image :type xpm :file "/home/larsi/src/emacs/trunk/etc/images/search.xpm") (image :type xpm :file "/home/larsi/src/emacs/trunk/etc/images/search.xpm") ("/home/larsi/src/emacs/trunk/etc/images/search.xpm") ("/home/larsi/src/emacs/trunk/etc/images/search.xpm") That is, the two filenames are not EQ. Is the toolbar code recreating the filenames on every redisplay or something? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no