From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check Date: Mon, 11 Jan 2021 22:02:24 +0100 Message-ID: <878s8z2nmn.fsf@gmail.com> References: <83sg7mggls.fsf@gnu.org> <83czymc8nq.fsf@gnu.org> <74b7a0a9-0eb3-7944-19d2-f72424ee72d7@dasyatidae.com> <83eeirfqbo.fsf@gnu.org> <87o8hvscfi.fsf@gmail.com> <8335z7fmnz.fsf@gnu.org> <87ft374axc.fsf@gmail.com> <5cb6a0ac-9fe9-bfc2-5642-3423bd043238@dasyatidae.com> <8735z748p1.fsf@gmail.com> <87y2gz2pxf.fsf@gmail.com> <83y2gzdx4o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, rtt@dasyatidae.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 11 22:03:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kz4LT-00080v-D5 for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jan 2021 22:03:23 +0100 Original-Received: from localhost ([::1]:58846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz4LS-0000QH-6I for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jan 2021 16:03:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz4Kc-0008Pm-8m for emacs-devel@gnu.org; Mon, 11 Jan 2021 16:02:30 -0500 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:41635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz4Ka-0005rH-EO; Mon, 11 Jan 2021 16:02:30 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id a12so181656wrv.8; Mon, 11 Jan 2021 13:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=rM1Oquoe2GIdA8jEG88lCSlpElF/0Iu54PLwmIFf5Dg=; b=IEtjGXoP1eTxsRUFukxiASDJQBbwHzIBCqRg5FrYWrZnLDkUEXy2zBvFGUi66cBylb X1WjUtjdM4F1uIGTAa4LdRtAbLhBjrKD3r+EIWFslh/4uCRbmJcTjQtRlT/XX4bS1Xte Gdc6WTbLLhZoB4g1yqNW3CELM83cWLWFvaab8io1f7DaWfuJyqWmqxleRSIvjt3jqGhZ GWOpQq3GFciKsspB/S/OG0SLQipr2eK4FypoAezme4msTafkpsthlO7W5LL181u+jiCl 1e21ogSTDliKaDnukQoakGHaUido4zTh5bAJ3nwfdDonzMTeURHurHb2KymQ77FJNvZA 3Erw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=rM1Oquoe2GIdA8jEG88lCSlpElF/0Iu54PLwmIFf5Dg=; b=fYTwL2kfOsXPovpzgstaj8yJU6tglQuTObyaaO+VBk19Ss0nxCY1t6eLemN2B+QTkt Lolt0pvC2+HguIo7kRkuUspFfpjcGKJvc9W/RgvjZnqU3CjDVd5qc+/wvI/cmRE7FFME 0EML/kGUTtQYxkfG6oxVqrf4lKVPO1fjPegSYKhA1ZIzhk2mjsrUiIUE3KjLIaYRtpeP y9Qinu46TwSNPQkklR9e7Oc/ByAqb2FWJSUkcXJzkEuV0gDPBMQ4C/iuCAKl73xu8J4e NrZ/Y/4HfxBoD+YR+lJeYmcQmS6CVSchmyTBv9zye/x9gipMb0BNQBSRHIfIZW8vGkOC tACQ== X-Gm-Message-State: AOAM5320oQ7M+HmWVsxbumjxtjw1hYQczvctnNfprhVOsuqHituRdWhm 7xXOrzBEyr5QWQcXpqGpCULBAhRKyAJcqQ== X-Google-Smtp-Source: ABdhPJxgsZfLy0mOHiFmha0SoVZ62SywsSdKTBe/17tIEYtjBuIWboS67wYpLG14jDZ76EbJovSsJw== X-Received: by 2002:a5d:400c:: with SMTP id n12mr939530wrp.218.1610398946295; Mon, 11 Jan 2021 13:02:26 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a861:69b6:6aaf:dbd3:8964]) by smtp.gmail.com with ESMTPSA id y2sm682828wma.6.2021.01.11.13.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 13:02:25 -0800 (PST) In-Reply-To: <83y2gzdx4o.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Jan 2021 22:41:43 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262937 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: Robin Tarsiger , Eli Zaretskii , >> emacs-devel@gnu.org >> Date: Mon, 11 Jan 2021 21:12:44 +0100 >>=20 >> Stefan Monnier writes: >>=20 >> >> Because the select implementation on windows does a one-byte readahead >> >> to see if data is available, which breaks UDP. I had a patch at one >> >> point to fix this, but I remember Eli not being very enthusiastic >> >> about it. I=CA=BCve attached what I think is the right version below = (my >> >> windows box died, so I can't be sure) >> > >> > How 'bout installing it but make it conditional on some config var? >> > And maybe set that config var if/when a UDP socket is requested? >>=20 >> I guess that=CA=BCs possible. I=CA=BCve now found the actual patch. If E= li >> thinks it=CA=BCs worth persuing, I can make it conditional, unless someo= ne >> wants to spare me the trouble of setting up a working Windows dev >> environment :-). > > My main concern is who will investigate the bug reports about this, > debug the problem, find fixes, etc.? If you or Stefan or someone else > volunteers, then please go ahead. But if you count on me, implicitly > or otherwise, then let's wait for a volunteer to emerge. Especially > in this area, where I'm far from being an expert. Don't forget that > two threads are involved in this game, which provides ample > opportunity for exciting deadlocks and races, apart of > network-specific issues. I don=CA=BCt think there=CA=BCs too much scope for thread-induced breakage,= but this is threads, so that statement might well come back to bite me :-) > (I'm sorry, but too often lately I'm the only one who gets to debug > and fix MS-Windows specific issues; if I don't do that, the build > remains broken for days. It's too much of a burden on me, and takes a > significant enough fraction of my time that I must be very cautious > with adventures. Otherwise, I won't be able to do my main job here, > which I already am barely capable of doing.) I can understand this. I don=CA=BCt run windows except in a VM, and the whole reason for the patch initially was to reduce the differences in the network implementation between different platforms (you can call this an obsessive desire for parity on my part if you like). If the cost of making udp processes work on Windows is not worth it, then we can stop here. Robert