From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 496bed5: Change command-completion-using-modes-p to defun Date: Sun, 21 Feb 2021 13:41:08 +0100 Message-ID: <878s7hmw4b.fsf@gnus.org> References: <20210220144350.4736.64583@vcs0.savannah.gnu.org> <20210220144351.6424B20B7C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23801"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 21 13:44:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDo5s-000656-0g for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Feb 2021 13:44:12 +0100 Original-Received: from localhost ([::1]:33978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDo5q-0008LG-VP for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Feb 2021 07:44:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDo34-0007HA-8h for emacs-devel@gnu.org; Sun, 21 Feb 2021 07:41:18 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:53072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDo32-00053s-I7 for emacs-devel@gnu.org; Sun, 21 Feb 2021 07:41:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kiZojc82j3h5wmbPMiEPk/x/TwJOjU4FTBDeENBLRqs=; b=JF1vBU8g3q5hAKCaBqw/UimEtg kPm4Zq4QVAVkNMg7qfBgCM/QEueyh9orfkVU4qDTG9hHq7OMANWEh70tzN7IURHTQRX0r1y0I9u1/ G2FdKudJkNJOlNhPy1k4zUMsGgnc7o/uYgP58YFT1o/TNQIduwcpp7T/RljiJjnJHRME=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDo2v-00081Z-G2; Sun, 21 Feb 2021 13:41:12 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEWwdmqWYVlhLitD MDKROS+nRjXAgXHCbFn///97ekHOAAAAAWJLR0QIht6VegAAAAd0SU1FB+UCFQwZOC1CPL4AAAGy SURBVDjLrZNNTgMxDIUzCA3bZuAC46QHIOEChMwBqBKx7Wr2ICSuz7Od+aNboqpS/eU5L8+pMf+8 rN396HZlXqeb7Z21w2gPImwWAcUYR7trJds6qcdgjz3wPURZz3YVcAkyInJHiXUMnogXwLj4kh6m SwLcBjrWRxUkllDr9SZHmoEo55w2cK9eDAnI6NXA4xEkcgq6uACfa2UJKbhbAeq1sjWE0q+dGEwA JTnStNwGVOI0xuWIaLIoaiH3F3C58uEjz+prBZOC1MDwBxQAme7jLUgMHhBUcDuAi+QF6BQWkGni Oe+AuoLdBoJOJxrfbOXKZwO0rI0XScnpvQH8muAeNy+4O8ArX7wBmIGirQ0UAUsdbs3MriCHiBqg Bbh4ZlAU8Hhf7anfQFqBh6CfZ4AXTchoXcYHgMcWFlBXMCuYOCDirJK0wv75+gmgzc36RiC49gz8 lLNrwBPeYT9f5wHx+ZySgpLOheIIu99EASBvoArpPJq6Fxm0aZnXiwvjwFtd8DjbrQAOop8S5odP FvCB0Dl5cr4mnmwgnyLAT5MUdL/IyL2/NNBeSlAF/hmX+AuOVbuTqAOyYwAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMS0wMi0yMVQxMjoyNTo1NiswMDowMH1yGHMAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjEtMDItMjFUMTI6MjU6NTYrMDA6MDAML6DPAAAAAElFTkSuQmCC X-Now-Playing: Insides's _Soft Bonds_: "The Softest Bonds Resist Resistance" In-Reply-To: (Stefan Monnier's message of "Sat, 20 Feb 2021 10:00:28 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265377 Archived-At: Stefan Monnier writes: >> -(define-inline command-completion-using-modes-p (symbol buffer) >> +(defun command-completion-using-modes-p (symbol buffer) > > `define-inline` can be used to define inlinable functions, but it's not > like `defsubst`: the body needs to be changed to look a bit more like > what a macro would look like. Right, that's what I thought, but Emacs didn't seem to beep at me when I used it, so I assumed that it had somehow been changed lately or something. I didn't notice that calling (command-completion-using-modes-p 'eww-form-select (current-buffer)) led to this appearing in my *Messages* buffer: Compiler-macro error for command-completion-using-modes-p: (wrong-type-argument bufferp (current-buffer)) By the way, changing it back to a defun doesn't seem to clear out the define-inline-ness? Hm... Ah: (symbol-plist 'command-completion-using-modes-p) => (edebug # compiler-macro command-completion-using-modes-p--inliner) Perhaps defun should (put 'command-completion-using-modes-p 'compiler-macro nil) ? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no