From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Mon, 08 Mar 2021 19:43:18 +0200 Organization: LINKOV.NET Message-ID: <878s6xwngp.fsf@mail.linkov.net> References: <831rd4romg.fsf@gnu.org> <83zgzsq7xn.fsf@gnu.org> <83v9afriqp.fsf@gnu.org> <83zgzjhvdn.fsf@gnu.org> <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> <87czwageno.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 08 19:19:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJKTA-000AUQ-FW for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Mar 2021 19:19:04 +0100 Original-Received: from localhost ([::1]:48318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJKT9-0007YE-6I for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Mar 2021 13:19:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJJwJ-0005QE-J1 for emacs-devel@gnu.org; Mon, 08 Mar 2021 12:45:07 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:58329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJJwH-0003Q1-At; Mon, 08 Mar 2021 12:45:07 -0500 X-Originating-IP: 91.129.108.46 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id E1FA120002; Mon, 8 Mar 2021 17:44:59 +0000 (UTC) Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266213 Archived-At: >> (defface help-key-binding >> - '((((class color) (min-colors 88) (background light)) :foreground "ForestGreen") >> - (((class color) (min-colors 88) (background dark)) :foreground "#44bc44") >> - (((class color grayscale) (background light)) :foreground "grey15") >> - (((class color grayscale) (background dark)) :foreground "grey85") >> - (t :foreground "ForestGreen")) >> + '((((class color) (min-colors 88) (background light)) :background "grey85") >> + (((class color) (min-colors 88) (background dark)) :background "grey25") >> + (((class color grayscale) (background light)) :background "grey85") >> + (((class color grayscale) (background dark)) :background "grey25") >> + (t :background "grey85")) >> "Face for keybindings in *Help* buffers. > > Excellent idea, let's do it. But grey85 is much too dark. Compare > grey85 (using M-x list-colors-display) to the hexadecimal values used in > the VSCode documentation or on GitHub, and see that they use very bright > greys (#f9f2f4 and #f6f8fa) while grey85 is #d9d9d9. > > I was toying with the much brighter grey95 (or perhaps something even > brighter -- again, compare the hexadecimal values). I completely agree. I retained "grey85" that was used for foreground, but it's not suitable for background. But OTOH, "grey95" is almost indistinguishable from the default white background. GitHub and GitLab use "grey90" for light and "grey25" for dark, so I changed now accordingly. > Did you test this on a terminal, BTW? What do you think? These faces look nice on a terminal. > Another thing I see is that they use more padding (a bigger square) > around the keybindings. We can muck around with the display properties > to achieve something similar, but the lines won't be even height. It > would automatically look slightly better here if our `line-spacing' > variable was something like 1, 2 or even 3 by default in these buffers. > (This would really be a better all-around choice in all buffers for > legibility, and is what is done on all modern text editors AFAICT.) When trying to use the style :background "grey90" :box (:line-width 2 :style released-button) the look is much nicer, but at the cost of wasting more vertical space for higher lines.