From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Thu, 08 Apr 2021 11:08:25 +0300 Organization: LINKOV.NET Message-ID: <878s5t9p1i.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <878s5wmsjp.fsf@mail.linkov.net> <87mtubz4ls.fsf@mail.linkov.net> <8735w22s9b.fsf@mail.linkov.net> <3ec7e2e58a3733a48ae9@heytings.org> <878s5tc0rn.fsf@mail.linkov.net> <3ec7e2e58a49d4f0ec99@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19238"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Ergus , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 08 10:16:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUPqG-0004qn-UC for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 10:16:44 +0200 Original-Received: from localhost ([::1]:46000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUPqF-0000Yn-WF for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 04:16:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUPoy-0008TW-GR for emacs-devel@gnu.org; Thu, 08 Apr 2021 04:15:24 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:59283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUPov-0006ve-Pp for emacs-devel@gnu.org; Thu, 08 Apr 2021 04:15:24 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 4C19F240018; Thu, 8 Apr 2021 08:15:16 +0000 (UTC) In-Reply-To: <3ec7e2e58a49d4f0ec99@heytings.org> (Gregory Heytings's message of "Wed, 07 Apr 2021 21:09:15 +0000") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267598 Archived-At: >> isearch-pre-command-hook could contain the same code >> that is currently duplicated in several commands: >> >> (setq isearch-just-started t) >> (goto-char (window-end)) ;; only this line needs to be >> ;; replaced with (funcall jumpform) >> (isearch-repeat 'forward) >> > > I'm not sure this would work, because it's not always (isearch-repeat > 'forward). For example with M-v it would be 'backward, regardless of the > current direction of the search. So I guess it means that another symbol > property would be necessary. A function attached to a symbol could return its search direction. Indeed, the definitions will be slightly longer, but still this is better than defining new commands. So this could look like: (put 'beginning-of-buffer 'isearch-match-scroll (lambda () (goto-char (point-min))) 'forward) (put 'end-of-buffer 'isearch-match-scroll (lambda () (goto-char (point-max)) 'backward)) (put 'scroll-up-command 'isearch-match-scroll (lambda () (goto-char (window-end)) 'forward)) (put 'scroll-down-command 'isearch-match-scroll (lambda () (goto-char (window-start)) 'backward)) > With C-p it's not clear (to me) if it should depend on the current > direction of the search or not. Should C-s C-p change the direction to > a backward search, or move to previous line and restart a forward search? The same question applies to scroll-up-command and scroll-down-command, e.g. in a forward search using scroll-up-command should change the direction? Maybe this preference should be specified by the same your new option isearch-allow-match-scroll, so when its value is t, then the enabled scrolling doesn't change the direction. But it does this when its value is e.g. 'change-direction'.