From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Adding transient to Emacs core Date: Tue, 27 Apr 2021 11:00:09 +0200 Message-ID: <878s54m7ae.fsf@bernoul.li> References: <87czuqi86o.fsf@bernoul.li> <87pmyhdvla.fsf@bernoul.li> <20210426.230318.88708181443886760.enometh@meer.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20915"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Madhu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 11:04:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbJdY-0005J2-RU for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 11:04:08 +0200 Original-Received: from localhost ([::1]:51590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbJdX-0001ao-Q7 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 05:04:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbJZp-0007K0-HP for emacs-devel@gnu.org; Tue, 27 Apr 2021 05:00:17 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:46742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbJZn-0003fd-3j for emacs-devel@gnu.org; Tue, 27 Apr 2021 05:00:17 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 3F7CA16B2B; Tue, 27 Apr 2021 11:00:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1619514010; bh=Ywqmkxvt3VskiEP8+vhVnPgX pCbwnETZLqtKlZPSiGM=; b=XmfwNuYSdPrVHqTSIVbLAvWC0UFdDYTZAG1eevhM G0ZG4bQuaJbg9b+0+BK2coeKH1fdhVfo/XolpM79ZGNXYRcvZXfv/8sWMr4lA7sd q1M8glMFpMe6ZxEjvV8Y8U2qqBoJO2ZXw+y0/bKuk8+ZjNxRU0epI4fGi1FH2uON XF8= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id JHVir7-WEPuD; Tue, 27 Apr 2021 11:00:10 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 10218166EA; Tue, 27 Apr 2021 11:00:10 +0200 (CEST) In-Reply-To: <20210426.230318.88708181443886760.enometh@meer.net> Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268523 Archived-At: Madhu writes: > [I apologize - I wasn't sensitized enough to your sensibilities.] Thanks! > I assume this is on the current `master' branch - and will be using > this shortly. I pushed it to transient's master a few months ago. The version in Emacs includes it as well. > I understans that you say this has been addressed. Correct. > If you say that (pop-up-windows nil) is not a valid customization, I > would strongly disagree with that. I have addressed this by let-binding that variable to t around the call to display-buffer. There's just no way around that because transient's buffer just has to be displayed somewhere other than the selected window. (Of course you can display it int another frame instead of in another window of the same frame, but then this binding should cause no offense, because in this scenario has no effect.) [I haven't pushed that to Emacs yet, but you can find it on transient's own master branch.] > If transient cannot handle input for some configuration then there > should be a fallback to emacs mechanisms that *can* handle input. I consider the above binding to be such a fallback. > If the package does not support use display-buffer according to the > design of display-buffer, I maintain it will have a negative impact if > adopted in the core and one is constrained to use it (instead of > keeping it optional) You can (setq transient-show-popup nil) to get this behavior: "If nil, then do not show the popup unless the user explicitly requests it, by pressing an incomplete prefix key sequence." Hm, you probably don't like that "an incomplete prefix key sequence" triggers the popup to be shown still. I might implement a "never" variant that never ever shows bindings the way transient was designed to do it, but instead makes `describe-bindings` available. That would add a feel to it that is very similar to that of regular prefix commands.