From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Date: Fri, 30 Apr 2021 01:54:14 +0300 Organization: LINKOV.NET Message-ID: <878s5090e9.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3570"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 30 01:20:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcFxf-0000qM-NN for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 01:20:47 +0200 Original-Received: from localhost ([::1]:59638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcFxe-0005kl-PF for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 19:20:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcFwq-0005BO-Fj for emacs-devel@gnu.org; Thu, 29 Apr 2021 19:19:56 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:50003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcFwn-0000cH-B0 for emacs-devel@gnu.org; Thu, 29 Apr 2021 19:19:56 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 119B4200004; Thu, 29 Apr 2021 23:19:46 +0000 (UTC) In-Reply-To: <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> (Daniel Mendler's message of "Thu, 29 Apr 2021 19:13:39 +0200") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268643 Archived-At: >> So the purpose of `affixation/annotation-function` and `group-function` >> seem orthogonal (tho we should be careful to make them work together: >> the affixation/annotation function will usually need the "full name" in >> order to decide what to add, but that the thing should be added to the >> text as shortened by `group-function`). > > Exactly, the grouping and affixation transformation functions are > orthogonal and should not be conflated. The patch I provided ensures > that the two features work well together - in both cases, with grouping > enabled and disabled. I agree. Then there are only minor details remaining: 1. for read-char-by-name, the first candidate of a group is displayed at the end of the same line with the group title (perhaps easy to fix); 2. it would be nice to support vertical/horizontal formats inside every group, not only one-column.