From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Bug-reference auto-setup for Rmail (please test) Date: Sun, 16 May 2021 10:53:55 +0200 Message-ID: <878s4f59u9.fsf@gnu.org> References: <87eee75d8n.fsf@gnu.org> <83o8dbukk9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13765"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.13; emacs 28.0.50 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 11:04:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liChI-0003I2-90 for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 11:04:28 +0200 Original-Received: from localhost ([::1]:40916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liChG-0006Lx-Cr for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 05:04:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCgb-0005eP-V0 for emacs-devel@gnu.org; Sun, 16 May 2021 05:03:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45166) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liCgb-00050O-NE for emacs-devel@gnu.org; Sun, 16 May 2021 05:03:45 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:54167) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCga-00018y-Gv; Sun, 16 May 2021 05:03:45 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailauth.nyi.internal (Postfix) with ESMTP id 0B9EF27C0054; Sun, 16 May 2021 05:03:44 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 16 May 2021 05:03:44 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeifedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepue eijedtudffgfetkeelueetuedvfedvheeitddugffhuddutedvffdvgfehvefgnecuffho mhgrihhnpehgnhhurdhorhhgnecukfhppeekjedrudeifedrfedurdduheegnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgv shhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelke dqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 May 2021 05:03:43 -0400 (EDT) In-reply-to: <83o8dbukk9.fsf@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269336 Archived-At: Eli Zaretskii writes: >> From: Tassilo Horn >> Date: Sun, 16 May 2021 09:23:21 +0200 >> >> What you need to do is activate `bug-reference-mode' in Rmail, so >> probably: >> >> (add-hook 'rmail-mode-hook #'bug-reference-mode) >> >> and then it'll try to guess the right `bug-reference-bug-regexp' and >> `bug-reference-url-format' based on the List-Id, To, From, and Cc >> headers according to the customize option >> `bug-reference-setup-from-mail-alist' which should at least have a >> suitable default value for (some) emacs-related mailinglists including >> emacs-devel. > > Thanks, but it is not clear to me what this feature is supposed to do, > and how do I test that. You say "it will try to guess", but what is > the expression of that guesswork, from the user perspective? With the default value of `bug-reference-setup-from-mail-alist', the user-visible effect would be that bug reference (bug#12345) would be fontified and clickable and browse that bug report on debbugs.gnu.org in terms of `browse-url'. >> There is one problem where I need implementation advice. The >> bug-reference auto-setup is a no-op if `bug-reference-bug-regexp' and >> `bug-reference-url-format' are already set (see >> `bug-reference--run-auto-setup'). So if you view an emacs-devel message >> first, it'll set those variables. When you move on to the next message >> (which might be completely unrelated to emacs), the variables are still >> set, so no new guesswork will be done. >> >> We'd need to nuke the buffer-local values and re-enable >> `bug-reference-mode' on switching messages, e.g., >> >> (add-hook 'rmail-show-message-hook #'rmail-bug-reference-setup) >> >> for a yet to be written rmail-bug-reference-setup which is a bit sad >> because for all other modes where I've added this auto-setup capability >> (Gnus, Mu4e [currently only in my ~/.emacs], rcirc, ERC, VC) the >> "normal" >> >> (add-hook '-hook #'bug-reference-mode) >> >> will do, that is, for Rmail the user would need to use a special >> function rather than just enabling `bug-reference-mode' in the mode of >> his choice. (Of course, this could be documented.) >> >> Alternatively, Rmail itself could check if `bug-reference-mode' is >> enabled, nuke the two variables, and call >> `bug-reference--run-auto-setup'. > > How is Rmail different in this regard from other MUA in Emacs? why do > you need something special for Rmail and not for the rest? Gnus and Mu4e create a fresh buffer with their viewing mode when viewing another mail just like you'd get another buffer when finding another file. Bye, Tassilo