From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: scratch/ns/refactor cc9dbaf 4/6: Fix macOS live resize drawing Date: Wed, 23 Jun 2021 16:32:47 +0200 Message-ID: <878s30slbk.fsf@gmail.com> References: <20210620155625.12886.44156@vcs0.savannah.gnu.org> <20210620155628.D095320B76@vcs0.savannah.gnu.org> <87czscso2l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 23 16:40:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw430-000Ac4-Kc for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Jun 2021 16:40:10 +0200 Original-Received: from localhost ([::1]:57176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lw42z-00041D-Lt for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Jun 2021 10:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw3vx-0006Nk-Qn for emacs-devel@gnu.org; Wed, 23 Jun 2021 10:32:54 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:36737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lw3vv-00036s-52 for emacs-devel@gnu.org; Wed, 23 Jun 2021 10:32:52 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id l12so2185002wrt.3 for ; Wed, 23 Jun 2021 07:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=h8YVYogommNnph/OzIMH6rj6KJ62Nw6CxUhkORqytxM=; b=dthxX8U08JZLbyrLlxh1M7nb2Dudx2xxwdfeKe0tT7bJGkCc3mksjyACOo50TGazui 8diAfKLglOGuVoa4OuxETQ8GyFg0ryjr1jWrCizWn/x9M4uBzz1Pkk0IDQ9ivikfREiW kv8yTIfMCwTu65ECA6IUGM3RfTe+qgTgjKtFwqCJJ0IKWzcxpmxL3ITRo5hh/Ra22wjj zZZBNlq52vPj0KfveRIWmhmwls3q7TvqJCHEh5n0nqZhju8AuY7EpcJyTlAWj3R87tvh nJHRa54wQUFgKWKUG6pJBFTIHIaIxqSOuuwLwAxnVFX7LwCpLS8T9kh0wxj1PbEyJhPb mlXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=h8YVYogommNnph/OzIMH6rj6KJ62Nw6CxUhkORqytxM=; b=D9a++rPvtAJpML0cpMRk1wAudd1fDYgaXFrbeqFCET/Rq/k13bN5O0K2zu0d5PrA4m OzYiqT7IvNT/Y+FKEtBVpMIem+CcofVFF/17PiP93hUMzkBRBkdGvaT2Dco5VmnZH1c6 Mned4kYqB2eiyGXZQamOEcnpWhFAKxFyQbh2tLZ7GdcTnEfn9aJa8SxEHh1B773NrKZi jhHeByUf3aA4NkZEC2UI+URmyuSkEB8fDSXy576/KgVuVvEz1vk0wJjQFtkJ4cmtDEev Q9tyMc3jnrYAnLdJw2Y8nFBFQ4/+UeyZaP9hb1y0gNM9BHVsqTfyq2ivE39OcZliz9YP 6MCw== X-Gm-Message-State: AOAM532fhbohKgeWE8F6anaoxw04Jk5b561kBEhG3Ko04ICUc/PyFqhX iwuAhikNK6kRG0oLY2estRRfGAi2J0s= X-Google-Smtp-Source: ABdhPJxr/hcegJi7MZv3+LrMMwLyuK88ObZ83MAPsFCdMlvBeQNM5/CeywJynG3Uc+Xtvd9L0opkeg== X-Received: by 2002:a05:6000:1889:: with SMTP id a9mr387753wri.288.1624458768625; Wed, 23 Jun 2021 07:32:48 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id b15sm265227wrr.27.2021.06.23.07.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 07:32:48 -0700 (PDT) In-Reply-To: (Alan Third's message of "Wed, 23 Jun 2021 15:05:32 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=rpluim@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270992 Archived-At: >>>>> On Wed, 23 Jun 2021 15:05:32 +0100, Alan Third said: Alan> Hi Robert, can you try uncommenting the code in layoutSublayersOfLayer Alan> and see if that fixes it? Hi Alan, this seems to do the job: diff --git i/src/nsterm.m w/src/nsterm.m index b5bfb242d5..5298466f27 100644 --- i/src/nsterm.m +++ w/src/nsterm.m @@ -8056,14 +8056,14 @@ - (void)layoutSublayersOfLayer:(CALayer *)layer however I can't understand why it would be different from viewWillDraw. I'll leave this commented out for now, but if nobody reports a crash it can be removed. */ - // bool owfi = waiting_for_input; - // waiting_for_input = 0; - // block_input (); + bool owfi = waiting_for_input; + waiting_for_input = 0; + block_input (); redisplay (); - // unblock_input (); - // waiting_for_input = owfi; + unblock_input (); + waiting_for_input = owfi; } } #endif Robert --