unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: emacs-devel@gnu.org
Subject: [ELPA] Add embark
Date: Sat, 30 Oct 2021 20:28:21 +0000	[thread overview]
Message-ID: <878ryai7fe.fsf@posteo.net> (raw)


Hi,

I'd like to propose adding the "embark"[0] package to GNU
ELPA. Functionality wise, it describes itself as "sort of right-click
contextual menu", and it seems to have attracted a lot of attention
recently.

The only issue is that all but one contributor has signed the copyright
assignment[1].  Yet Protesilaos Stavrou claims his contributions do not
amount to a "significant contribution", and thus should not block the
addition of Embark to GNU ELPA[2]:

> [...]
>
> A quick check:
> 
> - `eebbcf8` contains two typos and an indentation change.  Even they
>   are still applicable, they are a negligible change for our legal
>   purposes.
> 
> - `a35d9de` makes some changes to `embark-act`.  I would expect those
>   to no longer apply, given that this command has changed a lot over
>   time.  `git blame` tells me that nothing of that remains, but please
>   double check.
> 
> - `4790949` adds three lines of docs and a small code sample to the
>   README.  A quick look suggests that it no longer exists.
> 
> - `7c42885` changes the old implementation of keymaps and affects the
>   `embark-keymap` function.  That function no longer exists.  It has
>   been replaced by `embark-keymap-help` and `embark-keymap-prompter`.
>   Again, `git blame` tells me that no old code remains.
> 
> - `34ebcb9` is also about the old keymap implementation.  Those
>   have undergone thoroughgoing reform since last year.
> 
> In conclusion: what remains from DK's contributions does not block the
> process. Please verify those findings, otherwise embark is eligible
> for inclusion in GNU ELPA.
> 
> And I claim that this does not constitute a blocking issue, because I
> have read before on emacs-devel (I think by Richard Stallman?) that in
> cases where we cannot secure the paperwork, the relevant code needs to
> be written anew. In other words, Git history does not count, but only
> the current files. Though please confirm this with the Emacs
> maintainers.

If this is true, I would take care of adding Embark to GNU ELPA.

[0] https://github.com/oantolin/embark
[1] https://github.com/oantolin/embark/issues/233
[2] https://github.com/oantolin/embark/issues/233#issuecomment-890383731
-- 
	Philip Kaludercic



             reply	other threads:[~2021-10-30 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 20:28 Philip Kaludercic [this message]
2021-10-31  0:25 ` [ELPA] Add embark Daniel Martín
2021-10-31  4:20 ` Stefan Monnier
2021-10-31  8:22   ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ryai7fe.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).